[nautilus-actions] Add / fix / update some comments
- From: Pierre Wieser <pwieser src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus-actions] Add / fix / update some comments
- Date: Fri, 6 Jan 2012 07:32:20 +0000 (UTC)
commit 0c2eaf8974b8179bc4f6c24fab04531b6f3c4dc4
Author: Pierre Wieser <pwieser trychlos org>
Date: Thu Jan 5 20:40:19 2012 +0100
Add / fix / update some comments
ChangeLog | 8 ++++++++
src/core/na-icontext-factory.c | 5 +++++
src/core/na-iduplicable.c | 2 +-
src/core/na-object-action-factory.c | 9 +++++++--
src/core/na-object-action.c | 4 ++--
src/core/na-object-id-factory.c | 5 +++++
src/core/na-object-item-factory.c | 13 +++++++++++--
src/core/na-object-menu-factory.c | 5 +++++
8 files changed, 44 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 957e488..c7ac1dd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
2012-01-05 Pierre Wieser <pwieser trychlos org>
+ * src/core/na-icontext-factory.c:
+ * src/core/na-iduplicable.c:
+ * src/core/na-object-action-factory.c:
+ * src/core/na-object-action.c:
+ * src/core/na-object-id-factory.c:
+ * src/core/na-object-item-factory.c:
+ * src/core/na-object-menu-factory.c: Add/fix comments.
+
* src/core/na-export-format.h: Remove IPREFS_EXPORT_ definitions from here.
* src/core/na-exporter.c:
diff --git a/src/core/na-icontext-factory.c b/src/core/na-icontext-factory.c
index 5210d0e..0b51f58 100644
--- a/src/core/na-icontext-factory.c
+++ b/src/core/na-icontext-factory.c
@@ -38,6 +38,11 @@
#include <api/na-data-def.h>
#include <api/na-data-types.h>
+/*
+ * As of 3.2 non copyables data are:
+ * - multiple flag
+ */
+
NADataDef data_def_conditions [] = {
{ NAFO_DATA_BASENAMES,
diff --git a/src/core/na-iduplicable.c b/src/core/na-iduplicable.c
index ed19473..ed7c72c 100644
--- a/src/core/na-iduplicable.c
+++ b/src/core/na-iduplicable.c
@@ -485,7 +485,7 @@ na_iduplicable_set_origin( NAIDuplicable *object, const NAIDuplicable *origin )
* @object: the #NAIDuplicable object whose modification status is to be set.
* @modified: the new modification status #NAIDuplicable.
*
- * Sets the new modified of a duplicated #NAIDuplicable.
+ * Sets the new modification status of a duplicated #NAIDuplicable.
*
* Since: 2.30
* Deprecated: 3.1
diff --git a/src/core/na-object-action-factory.c b/src/core/na-object-action-factory.c
index a525543..71b0101 100644
--- a/src/core/na-object-action-factory.c
+++ b/src/core/na-object-action-factory.c
@@ -38,7 +38,12 @@
#include <api/na-data-def.h>
#include <api/na-data-types.h>
-extern NADataDef data_def_id[]; /* defined in na-object-id-factory.c */
+/*
+ * As of 3.2 non copyables data are:
+ * - n/a
+ */
+
+extern NADataDef data_def_id []; /* defined in na-object-id-factory.c */
extern NADataDef data_def_item []; /* defined in na-object-item-factory.c */
extern NADataDef data_def_conditions []; /* defined in na-icontext-factory.c */
@@ -227,7 +232,7 @@ static NADataDef data_def_action [] = {
/* all these data are pre-profiles data
* these are obsoleted since 1.9 (which was a non-official version)
- * readable but non writable, no default
+ * readable but non writable, no default, not copyable
*/
NADataDef data_def_action_v1 [] = {
diff --git a/src/core/na-object-action.c b/src/core/na-object-action.c
index 3760b08..02bc1c5 100644
--- a/src/core/na-object-action.c
+++ b/src/core/na-object-action.c
@@ -378,8 +378,8 @@ ifactory_object_get_groups( const NAIFactoryObject *instance )
/*
* at this time, we don't yet have read the profiles as this will be
- * triggered by ifactory_provider_read_done - we so just be able to deal with
- * action-specific properties (not check for profiles consistency)
+ * triggered by ifactory_provider_read_done - we so just are able to deal with
+ * action-specific properties (not to check for profiles consistency)
*/
static void
ifactory_object_read_done( NAIFactoryObject *instance, const NAIFactoryProvider *reader, void *reader_data, GSList **messages )
diff --git a/src/core/na-object-id-factory.c b/src/core/na-object-id-factory.c
index 24c3f4d..41fb7a9 100644
--- a/src/core/na-object-id-factory.c
+++ b/src/core/na-object-id-factory.c
@@ -36,6 +36,11 @@
#include <api/na-data-def.h>
#include <api/na-data-types.h>
+/*
+ * As of 3.2 non copyables data are:
+ * - the parent pointer
+ */
+
NADataDef data_def_id [] = {
/* this data is marked non readable / non writable as it has to be read
diff --git a/src/core/na-object-item-factory.c b/src/core/na-object-item-factory.c
index d69670f..00f2d6f 100644
--- a/src/core/na-object-item-factory.c
+++ b/src/core/na-object-item-factory.c
@@ -38,6 +38,15 @@
#include <api/na-data-def.h>
#include <api/na-data-types.h>
+/*
+ * As of 3.2 non copyables data are:
+ * - the type
+ * - non localized icon name
+ * - subitems pointers list and string list
+ * - read-only status
+ * - provider and provider data
+ */
+
NADataDef data_def_item [] = {
/* this data is marked as non readable as it has to be read specifically
@@ -320,7 +329,7 @@ NADataDef data_def_item [] = {
NA_DATA_TYPE_BOOLEAN,
"false",
FALSE,
- TRUE,
+ FALSE,
FALSE,
FALSE,
FALSE,
@@ -344,7 +353,7 @@ NADataDef data_def_item [] = {
NA_DATA_TYPE_POINTER,
NULL,
FALSE,
- TRUE,
+ FALSE,
FALSE,
FALSE,
FALSE,
diff --git a/src/core/na-object-menu-factory.c b/src/core/na-object-menu-factory.c
index 2ae8d26..7183707 100644
--- a/src/core/na-object-menu-factory.c
+++ b/src/core/na-object-menu-factory.c
@@ -40,6 +40,11 @@ extern NADataDef data_def_id []; /* defined in na-object-id-factory.c */
extern NADataDef data_def_item []; /* defined in na-object-item-factory.c */
extern NADataDef data_def_conditions []; /* defined in na-icontext-factory.c */
+/*
+ * As of 3.2 non copyables data are:
+ * - n/a
+ */
+
static NADataDef data_def_menu [] = {
{ NULL },
};
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]