[nautilus-actions] Review NactIMimetypesTab interface

[Pierre Wieser <pwieser src gnome org>]

commit 24a1eb9e9e3afd98a9236f3e50a6f17fef79f915
Author: Pierre Wieser <pwieser trychlos org>
Date:   Wed Jan 4 21:36:45 2012 +0100

    Review NactIMimetypesTab interface

 ChangeLog                      |    2 +
 src/nact/nact-imimetypes-tab.c |   76 +++++++++++++++++----------------------
 2 files changed, 35 insertions(+), 43 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 8563a74..542be0d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2012-01-04 Pierre Wieser <pwieser trychlos org>
 
+	* src/nact/nact-imimetypes-tab.c: Review NactIMimetypesTab interface.
+
 	* src/nact/nact-ifolders-tab.c: Review NactIFoldersTab interface.
 
 	* src/nact/nact-iexecution-tab.c: Review NactIExecutionTab interface.
diff --git a/src/nact/nact-imimetypes-tab.c b/src/nact/nact-imimetypes-tab.c
index 19ad195..54fdd8c 100644
--- a/src/nact/nact-imimetypes-tab.c
+++ b/src/nact/nact-imimetypes-tab.c
@@ -48,8 +48,7 @@ struct _NactIMimetypesTabInterfacePrivate {
 
 #define ITAB_NAME						"mimetypes"
 
-static gboolean st_initialized = FALSE;
-static gboolean st_finalized = FALSE;
+static guint st_initializations = 0;	/* interface initialization count */
 
 static GType   register_type( void );
 static void    interface_base_init( NactIMimetypesTabInterface *klass );
@@ -104,14 +103,14 @@ interface_base_init( NactIMimetypesTabInterface *klass )
 {
 	static const gchar *thisfn = "nact_imimetypes_tab_interface_base_init";
 
-	if( !st_initialized ){
+	if( !st_initializations ){
 
 		g_debug( "%s: klass=%p", thisfn, ( void * ) klass );
 
 		klass->private = g_new0( NactIMimetypesTabInterfacePrivate, 1 );
-
-		st_initialized = TRUE;
 	}
+
+	st_initializations += 1;
 }
 
 static void
@@ -119,11 +118,11 @@ interface_base_finalize( NactIMimetypesTabInterface *klass )
 {
 	static const gchar *thisfn = "nact_imimetypes_tab_interface_base_finalize";
 
-	if( st_initialized && !st_finalized ){
+	st_initializations -= 1;
 
-		g_debug( "%s: klass=%p", thisfn, ( void * ) klass );
+	if( !st_initializations ){
 
-		st_finalized = TRUE;
+		g_debug( "%s: klass=%p", thisfn, ( void * ) klass );
 
 		g_free( klass->private );
 	}
@@ -143,25 +142,22 @@ nact_imimetypes_tab_initial_load_toplevel( NactIMimetypesTab *instance )
 
 	g_return_if_fail( NACT_IS_IMIMETYPES_TAB( instance ));
 
-	if( st_initialized && !st_finalized ){
-
-		g_debug( "%s: instance=%p", thisfn, ( void * ) instance );
-
-		list = base_window_get_widget( BASE_WINDOW( instance ), "MimetypesTreeView" );
-		add = base_window_get_widget( BASE_WINDOW( instance ), "AddMimetypeButton" );
-		remove = base_window_get_widget( BASE_WINDOW( instance ), "RemoveMimetypeButton" );
-
-		nact_match_list_create_model(
-				BASE_WINDOW( instance ),
-				ITAB_NAME,
-				TAB_MIMETYPES,
-				list, add, remove,
-				( pget_filters ) get_mimetypes,
-				( pset_filters ) set_mimetypes,
-				NULL,
-				MATCH_LIST_MUST_MATCH_ONE_OF,
-				_( "Mimetype filter" ), TRUE );
-	}
+	g_debug( "%s: instance=%p (%s)", thisfn, ( void * ) instance, G_OBJECT_TYPE_NAME( instance ));
+
+	list = base_window_get_widget( BASE_WINDOW( instance ), "MimetypesTreeView" );
+	add = base_window_get_widget( BASE_WINDOW( instance ), "AddMimetypeButton" );
+	remove = base_window_get_widget( BASE_WINDOW( instance ), "RemoveMimetypeButton" );
+
+	nact_match_list_create_model(
+			BASE_WINDOW( instance ),
+			ITAB_NAME,
+			TAB_MIMETYPES,
+			list, add, remove,
+			( pget_filters ) get_mimetypes,
+			( pset_filters ) set_mimetypes,
+			NULL,
+			MATCH_LIST_MUST_MATCH_ONE_OF,
+			_( "Mimetype filter" ), TRUE );
 }
 
 /**
@@ -178,15 +174,15 @@ nact_imimetypes_tab_runtime_init_toplevel( NactIMimetypesTab *instance )
 
 	g_return_if_fail( NACT_IS_IMIMETYPES_TAB( instance ));
 
-	if( st_initialized && !st_finalized ){
-
-		g_debug( "%s: instance=%p", thisfn, ( void * ) instance );
+	g_debug( "%s: instance=%p (%s)", thisfn, ( void * ) instance, G_OBJECT_TYPE_NAME( instance ));
 
-		base_window_signal_connect( BASE_WINDOW( instance ),
-				G_OBJECT( instance ), MAIN_SIGNAL_SELECTION_CHANGED, G_CALLBACK( on_main_selection_changed ));
+	base_window_signal_connect(
+			BASE_WINDOW( instance ),
+			G_OBJECT( instance ),
+			MAIN_SIGNAL_SELECTION_CHANGED,
+			G_CALLBACK( on_main_selection_changed ));
 
-		nact_match_list_init_view( BASE_WINDOW( instance ), ITAB_NAME );
-	}
+	nact_match_list_init_view( BASE_WINDOW( instance ), ITAB_NAME );
 }
 
 void
@@ -196,10 +192,7 @@ nact_imimetypes_tab_all_widgets_showed( NactIMimetypesTab *instance )
 
 	g_return_if_fail( NACT_IS_IMIMETYPES_TAB( instance ));
 
-	if( st_initialized && !st_finalized ){
-
-		g_debug( "%s: instance=%p", thisfn, ( void * ) instance );
-	}
+	g_debug( "%s: instance=%p (%s)", thisfn, ( void * ) instance, G_OBJECT_TYPE_NAME( instance ));
 }
 
 /**
@@ -215,12 +208,9 @@ nact_imimetypes_tab_dispose( NactIMimetypesTab *instance )
 
 	g_return_if_fail( NACT_IS_IMIMETYPES_TAB( instance ));
 
-	if( st_initialized && !st_finalized ){
-
-		g_debug( "%s: instance=%p", thisfn, ( void * ) instance );
+	g_debug( "%s: instance=%p (%s)", thisfn, ( void * ) instance, G_OBJECT_TYPE_NAME( instance ));
 
-		nact_match_list_dispose( BASE_WINDOW( instance ), ITAB_NAME );
-	}
+	nact_match_list_dispose( BASE_WINDOW( instance ), ITAB_NAME );
 }
 
 static void