[gparted] Fix uninitialised read in OperationDetail::set_status()
- From: Curtis Gedak <gedakc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gparted] Fix uninitialised read in OperationDetail::set_status()
- Date: Wed, 4 Jan 2012 21:07:48 +0000 (UTC)
commit 377d26f0cc0d25b1706adc19d9949ec554be50a5
Author: Mike Fleetwood <mike fleetwood googlemail com>
Date: Sun Dec 18 12:25:52 2011 +0000
Fix uninitialised read in OperationDetail::set_status()
Setting the status and controlling the timing of operation details
initialised with OperationDetail(desc, status, font) uses a conditional
branch depending on the uninitialised variable this->status.
valgrind:
==28957== Conditional jump or move depends on uninitialised value(s)
==28957== at 0x80E4287:
GParted::OperationDetail::set_status(GParted::OperationDetailStatus)
(OperationDetail.cc:77)
OperationalDetail.cc:
75 void OperationDetail::set_status( OperationDetailStatus status )
76 {
>> 77 if ( this ->status != STATUS_ERROR )
78 {
79 switch ( status )
80 {
src/OperationDetail.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/OperationDetail.cc b/src/OperationDetail.cc
index 62766e5..dc7e96c 100644
--- a/src/OperationDetail.cc
+++ b/src/OperationDetail.cc
@@ -32,6 +32,7 @@ OperationDetail::OperationDetail()
OperationDetail::OperationDetail( const Glib::ustring & description, OperationDetailStatus status, Font font )
{
+ this ->status = STATUS_NONE; // prevent uninitialized member access
set_description( description, font ) ;
set_status( status ) ;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]