[gnome-video-arcade] Remove NOT NULL constraint from "manufacturer" column.



commit a6200b2e3b60da99cd069540a60a4f14172588ce
Author: Matthew Barnes <mbarnes redhat com>
Date:   Wed Jan 4 12:54:02 2012 -0500

    Remove NOT NULL constraint from "manufacturer" column.
    
    MAME 0.144 introduces some <game> entries with no "manufacturer"
    attribute, which fails our "game" table constraint and causes the
    entire SQLite transaction to be rolled back.
    
    Most if not all of these appear to be non-runnable devices.
    
    e.g. <game name="bsmt2000" isdevice="yes" runnable="no">
             <description>BSMT2000</description>
             <rom name="bsmt2000.bin" ...>
         </game>
    
    Indeed the -listxml DTD indicates the attribute is now optional:
    
        <!ELEMENT game (... manufacturer? ...)>

 src/gva-db.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/gva-db.c b/src/gva-db.c
index 275af3e..e8df9d1 100644
--- a/src/gva-db.c
+++ b/src/gva-db.c
@@ -63,7 +63,7 @@
                 "('good', 'best available', 'bad')), " \
                 "description NOT NULL, " \
                 "year, " \
-                "manufacturer NOT NULL, " \
+                "manufacturer, " \
                 "sound_channels, " \
                 "input_service DEFAULT 'no' " \
                 "CHECK (input_service in ('yes', 'no')), " \



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]