[glib] GSocket: fix a couple of return values



commit 8b96fb3761bb094d7c0044114f377934b9b00c51
Author: Claudio Saavedra <csaavedra igalia com>
Date:   Wed Jan 4 00:18:59 2012 +0200

    GSocket: fix a couple of return values
    
    g_socket_receive_with_blocking() and g_socket_send_with_blocking claim
    to return -1 in error, their return type is gssize, and yet they
    return FALSE if the initial g_return_val_if_fail() call fails.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667226

 gio/gsocket.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gio/gsocket.c b/gio/gsocket.c
index 6bf1213..1679280 100644
--- a/gio/gsocket.c
+++ b/gio/gsocket.c
@@ -1837,7 +1837,7 @@ g_socket_receive_with_blocking (GSocket       *socket,
 {
   gssize ret;
 
-  g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, FALSE);
+  g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, -1);
 
   if (!check_socket (socket, error))
     return -1;
@@ -2009,7 +2009,7 @@ g_socket_send_with_blocking (GSocket       *socket,
 {
   gssize ret;
 
-  g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, FALSE);
+  g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, -1);
 
   if (!check_socket (socket, error))
     return -1;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]