[gnome-color-manager] Fix a critial warning when setting the brightness



commit 9a05e00ee14035aa1eebbb5f097712c3e775d80c
Author: Richard Hughes <richard hughsie com>
Date:   Fri Feb 24 14:51:42 2012 +0000

    Fix a critial warning when setting the brightness
    
    Don't try to unref a floating reference...

 src/gcm-brightness.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/src/gcm-brightness.c b/src/gcm-brightness.c
index deadd48..f542ba7 100644
--- a/src/gcm-brightness.c
+++ b/src/gcm-brightness.c
@@ -53,7 +53,6 @@ gcm_brightness_set_percentage (GcmBrightness *brightness, guint percentage, GErr
 {
 	GcmBrightnessPrivate *priv = brightness->priv;
 	gboolean ret = FALSE;
-	GVariant *args = NULL;
 	GVariant *response = NULL;
 
 	g_return_val_if_fail (GCM_IS_BRIGHTNESS (brightness), FALSE);
@@ -67,13 +66,12 @@ gcm_brightness_set_percentage (GcmBrightness *brightness, guint percentage, GErr
 	}
 
 	/* execute sync method */
-	args = g_variant_new ("(u)", percentage),
 	response = g_dbus_connection_call_sync (priv->connection,
 						GPM_DBUS_SERVICE,
 						GPM_DBUS_PATH_BACKLIGHT,
 						GPM_DBUS_INTERFACE_BACKLIGHT,
 						"SetPercentage",
-						args,
+						g_variant_new ("(u)", percentage),
 						NULL,
 						G_DBUS_CALL_FLAGS_NONE,
 						-1, NULL, error);
@@ -83,8 +81,6 @@ gcm_brightness_set_percentage (GcmBrightness *brightness, guint percentage, GErr
 	/* success */
 	ret = TRUE;
 out:
-	if (args != NULL)
-		g_variant_unref (args);
 	if (response != NULL)
 		g_variant_unref (response);
 	return ret;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]