[gtk+] Don't unnecessarily clear background twice in no EXPOSE_MASK case



commit fcb58f3c83e8c525c6b2fb09eef9732a96714f08
Author: Alexander Larsson <alexl redhat com>
Date:   Sun Feb 19 11:55:22 2012 +0100

    Don't unnecessarily clear background twice in no EXPOSE_MASK case
    
    We already clear in begin_paint, no need to do it again. In fact, this
    will get the wrong result if the background has alpha.

 gdk/gdkwindow.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
---
diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c
index be7ac1a..3f541c6 100644
--- a/gdk/gdkwindow.c
+++ b/gdk/gdkwindow.c
@@ -3602,17 +3602,6 @@ gdk_window_clear_backing_region_direct (GdkWindow *window,
   cairo_surface_destroy (paint.surface);
 }
 
-
-static void
-gdk_window_clear_region_internal (GdkWindow *window,
-				  cairo_region_t *region)
-{
-  if (window->paint_stack)
-    gdk_window_clear_backing_region (window, region);
-  else
-    gdk_window_clear_backing_region_direct (window, region);
-}
-
 static void
 gdk_window_drop_cairo_surface (GdkWindow *window)
 {
@@ -3933,7 +3922,7 @@ _gdk_window_process_updates_recurse (GdkWindow *window,
 	   * piggyback on the implicit paint */
 
 	  gdk_window_begin_paint_region (window, clipped_expose_region);
-	  gdk_window_clear_region_internal (window, clipped_expose_region);
+	  /* The actual clear happens in begin_paint_region */
 	  gdk_window_end_paint (window);
 	}
     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]