[libpeas] Warn again when peas_extension_set_call() cannot call the method



commit 0e1385544e623aa89e676ea84ad9200c32f5f744
Author: Garrett Regier <garrettregier gmail com>
Date:   Thu Dec 8 19:12:33 2011 -0800

    Warn again when peas_extension_set_call() cannot call the method
    
    This was lost in 38f859208eb1d7a2eab9afc218bf41d67b389725.

 libpeas/peas-extension-set.c  |    7 +++++--
 tests/libpeas/extension-set.c |    2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/libpeas/peas-extension-set.c b/libpeas/peas-extension-set.c
index 19644c8..234c555 100644
--- a/libpeas/peas-extension-set.c
+++ b/libpeas/peas-extension-set.c
@@ -527,9 +527,12 @@ peas_extension_set_call_valist (PeasExtensionSet *set,
 
   callable_info = peas_gi_get_method_info (set->priv->exten_type, method_name);
 
-  /* Already warned */
   if (callable_info == NULL)
-    return FALSE;
+    {
+      g_warning ("Method '%s.%s' was not found",
+                 g_type_name (set->priv->exten_type), method_name);
+      return FALSE;
+    }
 
   n_args = g_callable_info_get_n_args (callable_info);
   g_return_val_if_fail (n_args >= 0, FALSE);
diff --git a/tests/libpeas/extension-set.c b/tests/libpeas/extension-set.c
index 7d889c5..64c5efc 100644
--- a/tests/libpeas/extension-set.c
+++ b/tests/libpeas/extension-set.c
@@ -252,7 +252,7 @@ test_extension_set_call_invalid (PeasEngine *engine)
 
   test_extension_set_activate (engine);
 
-  //testing_util_push_log_hook ("*Method 'PeasActivatable.invalid' not found*");
+  testing_util_push_log_hook ("Method 'PeasActivatable.invalid' was not found");
 
   extension_set = peas_extension_set_new (engine,
                                           PEAS_TYPE_ACTIVATABLE,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]