[gedit] Fix a possible memory leak



commit d8e176f0fee0ee2afa4ac4181e6c96054c3934db
Author: Daniel Trebbien <dtrebbien gmail com>
Date:   Thu Feb 9 17:28:09 2012 -0500

    Fix a possible memory leak
    
    It could be that the file info does not have the
    G_FILE_ATTRIBUTE_TIME_MODIFIED attribute set, and
    _gedit_document_check_externally_modified() would return before unrefing
    `info`.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=669809

 gedit/gedit-document.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/gedit/gedit-document.c b/gedit/gedit-document.c
index c60b9cc..eac99f2 100644
--- a/gedit/gedit-document.c
+++ b/gedit/gedit-document.c
@@ -1383,12 +1383,15 @@ _gedit_document_check_externally_modified (GeditDocument *doc)
 			GTimeVal timeval;
 
 			g_file_info_get_modification_time (info, &timeval);
+
 			g_object_unref (info);
 	
 			return (timeval.tv_sec > doc->priv->mtime.tv_sec) ||
 			       (timeval.tv_sec == doc->priv->mtime.tv_sec && 
 			       timeval.tv_usec > doc->priv->mtime.tv_usec);
 		}
+
+		g_object_unref (info);
 	}
 
 	return FALSE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]