[gtk+] accessible: Unset widget on dispose, not finalize
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] accessible: Unset widget on dispose, not finalize
- Date: Fri, 10 Feb 2012 12:24:25 +0000 (UTC)
commit 3b1d8beab0c213f7a46d76fcbaa5a93aeb2d0918
Author: Benjamin Otte <otte redhat com>
Date: Fri Feb 10 13:21:06 2012 +0100
accessible: Unset widget on dispose, not finalize
Unsetting the widget causes events to get emitted and we want to
(a) really emit that event to our signal handlers
(b) still be recognized as a real GObject while doing that
https://bugzilla.gnome.org/show_bug.cgi?id=669794
gtk/gtkaccessible.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gtk/gtkaccessible.c b/gtk/gtkaccessible.c
index ee908d3..cd9b43b 100644
--- a/gtk/gtkaccessible.c
+++ b/gtk/gtkaccessible.c
@@ -130,13 +130,13 @@ gtk_accessible_real_widget_unset (GtkAccessible *accessible)
}
static void
-gtk_accessible_finalize (GObject *object)
+gtk_accessible_dispose (GObject *object)
{
GtkAccessible *accessible = GTK_ACCESSIBLE (object);
gtk_accessible_set_widget (accessible, NULL);
- G_OBJECT_CLASS (gtk_accessible_parent_class)->finalize (object);
+ G_OBJECT_CLASS (gtk_accessible_parent_class)->dispose (object);
}
static void
@@ -152,7 +152,7 @@ gtk_accessible_class_init (GtkAccessibleClass *klass)
atkobject_class->ref_state_set = gtk_accessible_ref_state_set;
gobject_class->get_property = gtk_accessible_get_property;
gobject_class->set_property = gtk_accessible_set_property;
- gobject_class->finalize = gtk_accessible_finalize;
+ gobject_class->dispose = gtk_accessible_dispose;
g_object_class_install_property (gobject_class,
PROP_WIDGET,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]