[eog-plugins] exif-display: Avoid possible memory leak in error case
- From: Felix Riemann <friemann src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [eog-plugins] exif-display: Avoid possible memory leak in error case
- Date: Wed, 8 Feb 2012 20:10:07 +0000 (UTC)
commit 4cf418bf34792dbd8bfa649b47f354f9de0b3448
Author: Felix Riemann <friemann gnome org>
Date: Tue Feb 7 20:11:32 2012 +0100
exif-display: Avoid possible memory leak in error case
plugins/exif-display/eog-exif-display-plugin.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/plugins/exif-display/eog-exif-display-plugin.c b/plugins/exif-display/eog-exif-display-plugin.c
index 8e0d2ca..c313053 100644
--- a/plugins/exif-display/eog-exif-display-plugin.c
+++ b/plugins/exif-display/eog-exif-display-plugin.c
@@ -307,15 +307,6 @@ calculate_histogram (EogExifDisplayPlugin *plugin, EogImage *eog_image)
g_free (plugin->histogram_values_blue);
g_free (plugin->histogram_values_rgb);
- histogram_values_red_temp = g_new0 (int, 256);
-
- plugin->histogram_values_green = g_new0 (int, 256);
- plugin->histogram_values_blue = g_new0 (int, 256);
- plugin->max_of_array_sums = 0;
-
- plugin->histogram_values_rgb = g_new0 (int, 256);
- plugin->max_of_array_sums_rgb = 0;
-
image_pixbuf = eog_image_get_pixbuf (eog_image);
if (image_pixbuf == NULL) {
return FALSE;
@@ -334,6 +325,15 @@ calculate_histogram (EogExifDisplayPlugin *plugin, EogImage *eog_image)
pixels = gdk_pixbuf_get_pixels (image_pixbuf);
+ histogram_values_red_temp = g_new0 (int, 256);
+
+ plugin->histogram_values_green = g_new0 (int, 256);
+ plugin->histogram_values_blue = g_new0 (int, 256);
+ plugin->max_of_array_sums = 0;
+
+ plugin->histogram_values_rgb = g_new0 (int, 256);
+ plugin->max_of_array_sums_rgb = 0;
+
for (row = 0; row < height; row++) {
guchar *row_cur_idx = pixels + row*rowstride;
for (col = 0; col < width; col++) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]