[nautilus-actions] Review na_gtk_utils_dump_children() usage
- From: Pierre Wieser <pwieser src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus-actions] Review na_gtk_utils_dump_children() usage
- Date: Mon, 6 Feb 2012 20:08:50 +0000 (UTC)
commit 8775d7f3cdd8a370dc0b43b8e13df10ce47b761e
Author: Pierre Wieser <pwieser trychlos org>
Date: Sat Feb 4 19:20:17 2012 +0100
Review na_gtk_utils_dump_children() usage
ChangeLog | 7 +++++++
src/nact/base-window.c | 3 +++
src/nact/nact-assistant-export.c | 4 ----
src/nact/nact-main-window.c | 6 +++++-
src/nact/nact-tree-view.c | 6 ------
5 files changed, 15 insertions(+), 11 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 726fd6b..3817580 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2012-02-04 Pierre Wieser <pwieser trychlos org>
+ * src/nact/base-window.c (on_initialize_gtk_toplevel_class_handler):
+ Always dump Gtk hierarchy in maintainer mode.
+
+ * src/nact/nact-assistant-export.c (format_tree_view_initialize_gtk):
+ * src/nact/nact-main-window.c (on_base_initialize_gtk):
+ * src/nact/nact-tree-view.c (nact_tree_view_new): Updated accordingly.
+
* src/nact/nact-icommand-tab.c (on_base_initialize_gtk):
Dynamically converts GtkTable to GtkGrid.
diff --git a/src/nact/base-window.c b/src/nact/base-window.c
index 9dafbce..0a2da20 100644
--- a/src/nact/base-window.c
+++ b/src/nact/base-window.c
@@ -801,6 +801,9 @@ on_initialize_gtk_toplevel_class_handler( BaseWindow *window, GtkWindow *topleve
BASE_WINDOW_GET_CLASS( window )->initialize_gtk_toplevel( window, toplevel );
}
}
+#ifdef NA_MAINTAINER_MODE
+ base_window_dump_children( window );
+#endif
}
static void
diff --git a/src/nact/nact-assistant-export.c b/src/nact/nact-assistant-export.c
index b618d8b..d73f92c 100644
--- a/src/nact/nact-assistant-export.c
+++ b/src/nact/nact-assistant-export.c
@@ -488,10 +488,6 @@ format_tree_view_initialize_gtk( NactAssistantExport *window )
page = gtk_assistant_get_nth_page( assistant, ASSIST_PAGE_FORMAT_SELECTION );
tree_view = na_gtk_utils_find_widget_by_name( GTK_CONTAINER( page ), "p3-ExportFormatTreeView" );
-#ifdef NA_MAINTAINER_MODE
- na_gtk_utils_dump_children( GTK_CONTAINER( tree_view ));
-#endif
-
na_ioptions_list_gtk_init( NA_IOPTIONS_LIST( window ), tree_view, TRUE );
gtk_assistant_set_page_complete( assistant, page, TRUE );
diff --git a/src/nact/nact-main-window.c b/src/nact/nact-main-window.c
index 38ad685..1afcd85 100644
--- a/src/nact/nact-main-window.c
+++ b/src/nact/nact-main-window.c
@@ -851,8 +851,12 @@ on_base_initialize_gtk( NactMainWindow *window, GtkWindow *toplevel, gpointer us
g_return_if_fail( NACT_IS_MAIN_WINDOW( window ));
if( !window->private->dispose_has_run ){
+
g_debug( "%s: window=%p, toplevel=%p, user_data=%p",
- thisfn, ( void * ) window, ( void * ) toplevel, ( void * ) user_data );
+ thisfn,
+ ( void * ) window,
+ ( void * ) toplevel,
+ ( void * ) user_data );
/* create the tree view which will create itself its own tree model
*/
diff --git a/src/nact/nact-tree-view.c b/src/nact/nact-tree-view.c
index d8f7153..38a8a05 100644
--- a/src/nact/nact-tree-view.c
+++ b/src/nact/nact-tree-view.c
@@ -637,12 +637,6 @@ nact_tree_view_new( BaseWindow *window, GtkContainer *parent, const gchar *treev
TREE_PROP_MODE, mode,
NULL );
-#if 0
-# ifdef NA_MAINTAINER_MODE
- na_gtk_utils_dump_children( parent );
-# endif
-#endif
-
return( view );
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]