[f-spot] Added a FIXME tag about a possible race condition
- From: Stephen Shaw <sshaw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [f-spot] Added a FIXME tag about a possible race condition
- Date: Wed, 1 Feb 2012 23:50:03 +0000 (UTC)
commit 25ce36294189ccb87345a04f9326ca1568ef7720
Author: Stephen Shaw <sshaw decriptor com>
Date: Wed Feb 1 10:43:22 2012 -0700
Added a FIXME tag about a possible race condition
src/Clients/MainApp/FSpot/PhotoStore.cs | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/Clients/MainApp/FSpot/PhotoStore.cs b/src/Clients/MainApp/FSpot/PhotoStore.cs
index 276102e..79f823f 100644
--- a/src/Clients/MainApp/FSpot/PhotoStore.cs
+++ b/src/Clients/MainApp/FSpot/PhotoStore.cs
@@ -648,10 +648,12 @@ namespace FSpot {
where_added = true;
}
Database.Execute (query_builder.ToString ());
-
+
int minyear = Int32.MaxValue;
int maxyear = Int32.MinValue;
-
+
+ // FIXME: There appears to be a race condition here where it tries to query the population
+ // table before Database.Execute (query_builder.ToString ()); creates it.
IDataReader reader = Database.Query ("SELECT COUNT (*) as count, month from population GROUP BY month");
while (reader.Read ()) {
string yyyymm = reader ["month"].ToString ();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]