[gtk+/wip/combobox-css-cleanups: 8/12] combobox: cleanup allocation of children in list mode

[Cosimo Cecchi <cosimoc src gnome org>]

commit f16d75eb39a31f1e4b3c5ee760edacb3308b10e0
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Tue Jan 31 18:45:09 2012 -0500

    combobox: cleanup allocation of children in list mode
    
    Instead of setting the same values for child allocation in different
    places, just do it once.

 gtk/gtkcombobox.c |   19 ++++---------------
 1 files changed, 4 insertions(+), 15 deletions(-)
---
diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index d720667..b9b6f54 100644
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -2681,18 +2681,14 @@ gtk_combo_box_size_allocate (GtkWidget     *widget,
       if (is_rtl)
         child.x = button_allocation.x + button_allocation.width;
       else
-        child.x = allocation->x;
+        child.x = allocation->x + padding.left + border_width;
 
-      child.y = allocation->y;
-      child.width = allocation->width - button_allocation.width - (padding.left + padding.right);
-      child.height = button_allocation.height;
+      child.y = allocation->y + padding.top + border_width;
+      child.width = allocation->width - button_allocation.width - (2 * border_width + padding.left + padding.right);
+      child.height = button_allocation.height - 2 * border_width;
 
       if (priv->cell_view_frame)
         {
-          child.x += padding.left + border_width;
-          child.y += padding.top + border_width;
-          child.width = MAX (1, child.width - (2 * border_width) - (padding.left + padding.right));
-          child.height = MAX (1, child.height - (2 * border_width) - (padding.top + padding.bottom));
           gtk_widget_size_allocate (priv->cell_view_frame, &child);
 
           /* restrict allocation of the child into the frame box if it's present */
@@ -2709,13 +2705,6 @@ gtk_combo_box_size_allocate (GtkWidget     *widget,
               child.height -= (2 * border_width) + frame_padding.top + frame_padding.bottom;
             }
         }
-      else
-        {
-          child.x += padding.left + border_width;
-          child.y += padding.top + border_width;
-          child.width -= (2 * border_width) - (padding.left + padding.right);
-          child.height -= (2 * border_width) - (padding.top + padding.bottom);
-        }
 
       if (gtk_widget_get_visible (priv->popup_window))
         {