[gjs] object: use g_signal_connect_closure_by_id



commit 412cb8d48339dc4307bbfdd006b8d90abf609e11
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Wed Dec 19 01:37:53 2012 +0100

    object: use g_signal_connect_closure_by_id
    
    We parse the signal name few lines earlier, we might just as well use
    the parsed id.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690688

 gi/object.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/gi/object.c b/gi/object.c
index eddbaec..5857fdb 100644
--- a/gi/object.c
+++ b/gi/object.c
@@ -1228,10 +1228,11 @@ real_connect_func(JSContext *context,
     connect_data->closure = closure;
     g_closure_add_invalidate_notifier(closure, connect_data, signal_connection_invalidated);
 
-    id = g_signal_connect_closure(priv->gobj,
-                                  signal_name,
-                                  closure,
-                                  after);
+    id = g_signal_connect_closure_by_id(priv->gobj,
+                                        signal_id,
+                                        signal_detail,
+                                        closure,
+                                        after);
 
     if (!JS_NewNumberValue(context, id, &retval)) {
         g_signal_handler_disconnect(priv->gobj, id);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]