[gnome-shell] workspaceThumbnail: handle show/hide when entering/leaving the overview
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] workspaceThumbnail: handle show/hide when entering/leaving the overview
- Date: Mon, 17 Dec 2012 12:25:56 +0000 (UTC)
commit d2c6149923f0412c4abc297bb3c2ec53aa761689
Author: Cosimo Cecchi <cosimoc gnome org>
Date: Thu Dec 13 10:39:52 2012 -0500
workspaceThumbnail: handle show/hide when entering/leaving the overview
Handle this internally, instead of having WorkspacesDisplay show/hide
us.
https://bugzilla.gnome.org/show_bug.cgi?id=690175
js/ui/workspaceThumbnail.js | 9 +++++++--
js/ui/workspacesView.js | 2 --
2 files changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index 71ea13d..b381dab 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -546,6 +546,11 @@ const ThumbnailsBox = new Lang.Class({
this.actor.connect('button-release-event', Lang.bind(this, this._onButtonRelease));
this.actor.connect('scroll-event', Lang.bind(this, this._onScrollEvent));
+ Main.overview.connect('showing',
+ Lang.bind(this, this._createThumbnails));
+ Main.overview.connect('hidden',
+ Lang.bind(this, this._destroyThumbnails));
+
Main.overview.connect('item-drag-begin',
Lang.bind(this, this._onDragBegin));
Main.overview.connect('item-drag-end',
@@ -733,7 +738,7 @@ const ThumbnailsBox = new Lang.Class({
}
},
- show: function() {
+ _createThumbnails: function() {
this._switchWorkspaceNotifyId =
global.window_manager.connect('switch-workspace',
Lang.bind(this, this._activeWorkspaceChanged));
@@ -765,7 +770,7 @@ const ThumbnailsBox = new Lang.Class({
this._updateSwitcherVisibility();
},
- hide: function() {
+ _destroyThumbnails: function() {
if (this._switchWorkspaceNotifyId > 0) {
global.window_manager.disconnect(this._switchWorkspaceNotifyId);
this._switchWorkspaceNotifyId = 0;
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 781c0e4..5e66c21 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -573,7 +573,6 @@ const WorkspacesDisplay = new Lang.Class({
this._updateZoom();
this._controls.show();
- this._thumbnailsBox.show();
this._updateWorkspacesViews();
@@ -611,7 +610,6 @@ const WorkspacesDisplay = new Lang.Class({
hide: function() {
this._controls.hide();
- this._thumbnailsBox.hide();
if (!this._alwaysZoomOut)
this.zoomFraction = 0;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]