[gnome-control-center] printers: Avoid possible crash
- From: Marek KaÅÃk <mkasik src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] printers: Avoid possible crash
- Date: Wed, 12 Dec 2012 12:34:17 +0000 (UTC)
commit 9afed77bdec41a5853be36de960465d92d70b5a8
Author: Marek Kasik <mkasik redhat com>
Date: Wed Dec 12 12:34:58 2012 +0100
printers: Avoid possible crash
Unlink given PPD file and free its filename
as soon as it is not required. This avoids
possible double free.
https://bugzilla.gnome.org/show_bug.cgi?id=690091
panels/printers/pp-new-printer.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/panels/printers/pp-new-printer.c b/panels/printers/pp-new-printer.c
index 3da5117..038a2ad 100644
--- a/panels/printers/pp-new-printer.c
+++ b/panels/printers/pp-new-printer.c
@@ -1081,6 +1081,12 @@ get_missing_executables_cb (GObject *source_object,
GList *executables = NULL;
GList *item;
+ if (data->ppd_file_name)
+ {
+ g_unlink (data->ppd_file_name);
+ g_clear_pointer (&data->ppd_file_name, g_free);
+ }
+
output = g_dbus_connection_call_finish (G_DBUS_CONNECTION (source_object),
res,
&error);
@@ -1157,12 +1163,6 @@ DBus method \"MissingExecutables\" to find missing executables and filters.");
g_object_unref (source_object);
install_missing_executables_cb (data);
}
-
- if (data->ppd_file_name)
- {
- g_unlink (data->ppd_file_name);
- g_clear_pointer (&data->ppd_file_name, g_free);
- }
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]