[libsoup] soup-session: fix a possible crash



commit a2a4fccfa8ebd09aea232913eaa3bf1752038e40
Author: Dan Winship <danw gnome org>
Date:   Tue Dec 11 17:33:14 2012 +0100

    soup-session: fix a possible crash
    
    Calling soup_session_unqueue_item() will unref the item, so we need to
    add an extra ref if we want to ensure that it's still valid afterward.

 libsoup/soup-session.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/libsoup/soup-session.c b/libsoup/soup-session.c
index a5fac7d..f44bf8e 100644
--- a/libsoup/soup-session.c
+++ b/libsoup/soup-session.c
@@ -1793,9 +1793,11 @@ soup_session_process_queue_item (SoupSession          *session,
 				break;
 			}
 
+			soup_message_queue_item_ref (item);
 			soup_session_unqueue_item (session, item);
 			if (item->async && item->callback)
 				item->callback (session, item->msg, item->callback_data);
+			soup_message_queue_item_unref (item);
 			return;
 
 		default:



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]