[gnome-documents] gnome-documents.in: Don't leave shell interpreter hanging around
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-documents] gnome-documents.in: Don't leave shell interpreter hanging around
- Date: Wed, 5 Dec 2012 19:39:39 +0000 (UTC)
commit 92726c901909d4c94fabd09a78bcbd9c4eba3d38
Author: Colin Walters <walters verbum org>
Date: Wed Dec 5 14:33:04 2012 -0500
gnome-documents.in: Don't leave shell interpreter hanging around
Basically, wrapper shell scripts like this should always end in 'exec'
- otherwise you have a pointless process hanging around. Even worse,
because gnome-documents.in doesn't use "set -e", the shell script will
actually mask return values if e.g. the gjs process exits abormally.
https://bugzilla.gnome.org/show_bug.cgi?id=689727
src/gnome-documents-search-provider.in | 2 +-
src/gnome-documents.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/gnome-documents-search-provider.in b/src/gnome-documents-search-provider.in
index 36e9968..e45ae88 100644
--- a/src/gnome-documents-search-provider.in
+++ b/src/gnome-documents-search-provider.in
@@ -4,4 +4,4 @@ export GJS_PATH="@pkgdatadir@/js${GJS_PATH:+:GJS_PATH}"
export GI_TYPELIB_PATH="@pkglibdir@/girepository-1.0${GI_TYPELIB_PATH:+:GI_TYPELIB_PATH}"
export LD_LIBRARY_PATH="@pkglibdir ${LD_LIBRARY_PATH:+:LD_LIBRARY_PATH}"
- GJS_CONSOLE@ -I @pkgdatadir@/js -c "const SearchProvider = imports.shellSearchProvider; SearchProvider.start();"
+exec @GJS_CONSOLE@ -I @pkgdatadir@/js -c "const SearchProvider = imports.shellSearchProvider; SearchProvider.start();"
diff --git a/src/gnome-documents.in b/src/gnome-documents.in
index 211703d..94f970d 100644
--- a/src/gnome-documents.in
+++ b/src/gnome-documents.in
@@ -12,4 +12,4 @@ if test x"$GJS_DEBUG_TOPICS" = x ; then
export GJS_DEBUG_TOPICS="JS ERROR;JS LOG"
fi
- GJS_CONSOLE@ -I @pkgdatadir@/js -c "const Main = imports.main; Main.start();" "$@"
+exec @GJS_CONSOLE@ -I @pkgdatadir@/js -c "const Main = imports.main; Main.start();" "$@"
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]