[cogl] pipeline: remove unused _cogl_pipeline_get_layers
- From: Robert Bragg <rbragg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cogl] pipeline: remove unused _cogl_pipeline_get_layers
- Date: Thu, 30 Aug 2012 11:32:24 +0000 (UTC)
commit e855ad9d9365bf0900b85aac824befbdd25bc978
Author: Robert Bragg <robert linux intel com>
Date: Sun Aug 26 01:41:32 2012 +0100
pipeline: remove unused _cogl_pipeline_get_layers
_cogl_pipeline_get_layers used to be required to support the public
cogl_pipeline_get_layers api but that api has been removed so this
can go too.
Reviewed-by: Neil Roberts <neil linux intel com>
cogl/cogl-pipeline-private.h | 8 --------
cogl/cogl-pipeline.c | 40 ----------------------------------------
2 files changed, 0 insertions(+), 48 deletions(-)
---
diff --git a/cogl/cogl-pipeline-private.h b/cogl/cogl-pipeline-private.h
index d315b45..26b7cf1 100644
--- a/cogl/cogl-pipeline-private.h
+++ b/cogl/cogl-pipeline-private.h
@@ -451,10 +451,6 @@ struct _CoglPipeline
* pipelines with only a few layers... */
CoglPipelineLayer *short_layers_cache[3];
- /* The deprecated cogl_pipeline_get_layers() API returns a
- * const GList of layers, which we track here... */
- GList *deprecated_get_layers_list;
-
/* XXX: consider adding an authorities cache to speed up sparse
* property value lookups:
* CoglPipeline *authorities_cache[COGL_PIPELINE_N_SPARSE_PROPERTIES];
@@ -484,7 +480,6 @@ struct _CoglPipeline
unsigned int real_blend_enable:1;
unsigned int layers_cache_dirty:1;
- unsigned int deprecated_get_layers_list_dirty:1;
/* For debugging purposes it's possible to associate a static const
* string with a pipeline which can be an aid when trying to trace
@@ -925,9 +920,6 @@ _cogl_pipeline_prune_to_n_layers (CoglPipeline *pipeline, int n);
* API to support the deprecate cogl_pipeline_layer_xyz functions...
*/
-const GList *
-_cogl_pipeline_get_layers (CoglPipeline *pipeline);
-
typedef CoglBool (*CoglPipelineInternalLayerCallback) (CoglPipelineLayer *layer,
void *user_data);
diff --git a/cogl/cogl-pipeline.c b/cogl/cogl-pipeline.c
index 855d815..429e46a 100644
--- a/cogl/cogl-pipeline.c
+++ b/cogl/cogl-pipeline.c
@@ -339,8 +339,6 @@ _cogl_pipeline_copy (CoglPipeline *src, CoglBool is_weak)
*/
pipeline->layers_cache_dirty = TRUE;
- pipeline->deprecated_get_layers_list = NULL;
- pipeline->deprecated_get_layers_list_dirty = TRUE;
pipeline->fragend = src->fragend;
@@ -458,8 +456,6 @@ _cogl_pipeline_free (CoglPipeline *pipeline)
if (pipeline->differences & COGL_PIPELINE_STATE_FRAGMENT_SNIPPETS)
_cogl_pipeline_snippet_list_free (&pipeline->big_state->fragment_snippets);
- g_list_free (pipeline->deprecated_get_layers_list);
-
recursively_free_layer_caches (pipeline);
g_slice_free (CoglPipeline, pipeline);
@@ -2312,42 +2308,6 @@ cogl_pipeline_remove_layer (CoglPipeline *pipeline, int layer_index)
_cogl_pipeline_update_blend_enable (pipeline, COGL_PIPELINE_STATE_LAYERS);
}
-static CoglBool
-prepend_layer_to_list_cb (CoglPipelineLayer *layer,
- void *user_data)
-{
- GList **layers = user_data;
-
- *layers = g_list_prepend (*layers, layer);
- return TRUE;
-}
-
-/* TODO: deprecate this API and replace it with
- * cogl_pipeline_foreach_layer
- * TODO: update the docs to note that if the user modifies any layers
- * then the list may become invalid.
- */
-const GList *
-_cogl_pipeline_get_layers (CoglPipeline *pipeline)
-{
- _COGL_RETURN_VAL_IF_FAIL (cogl_is_pipeline (pipeline), NULL);
-
- if (!pipeline->deprecated_get_layers_list_dirty)
- g_list_free (pipeline->deprecated_get_layers_list);
-
- pipeline->deprecated_get_layers_list = NULL;
-
- _cogl_pipeline_foreach_layer_internal (pipeline,
- prepend_layer_to_list_cb,
- &pipeline->deprecated_get_layers_list);
- pipeline->deprecated_get_layers_list =
- g_list_reverse (pipeline->deprecated_get_layers_list);
-
- pipeline->deprecated_get_layers_list_dirty = 0;
-
- return pipeline->deprecated_get_layers_list;
-}
-
int
cogl_pipeline_get_n_layers (CoglPipeline *pipeline)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]