[gnome-boxes] Fix misuse of N_()



commit f43ac673c2c53c74fe5f8a2e2e28bf4aabece0eb
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Mon Aug 27 17:23:31 2012 +0200

    Fix misuse of N_()
    
    There are a few places where N_() is used without calling gettext()
    on the returned string. However, glib documentation for N_() says:
    "Only marks a string for translation. This is useful in situations where
    the translated strings can't be directly used, e.g. in string array
    initializers. To get the translated string, call gettext() at runtime."
    
    Since these uses are in places where _() can safely be called,
    use that instead.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=682808

 src/main.vala |   12 ++++++------
 src/util.vala |    2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/src/main.vala b/src/main.vala
index 83ddcdb..9ada8fd 100644
--- a/src/main.vala
+++ b/src/main.vala
@@ -71,16 +71,16 @@ private async void run_checks () {
     var selinux_context_default = yield Boxes.check_selinux_context_default (out selinux_context_diagnosis);
 
     // FIXME: add proper UI & docs
-    GLib.stdout.printf (N_("â The CPU is capable of virtualization: %s\n").printf (Boxes.yes_no (cpu)));
-    GLib.stdout.printf (N_("â The KVM module is loaded: %s\n").printf (Boxes.yes_no (kvm)));
-    GLib.stdout.printf (N_("â Libvirt KVM guest available: %s\n").printf (Boxes.yes_no (libvirt_kvm)));
+    GLib.stdout.printf (_("â The CPU is capable of virtualization: %s\n").printf (Boxes.yes_no (cpu)));
+    GLib.stdout.printf (_("â The KVM module is loaded: %s\n").printf (Boxes.yes_no (kvm)));
+    GLib.stdout.printf (_("â Libvirt KVM guest available: %s\n").printf (Boxes.yes_no (libvirt_kvm)));
 
-    GLib.stdout.printf (N_("â The SELinux context is default: %s\n").printf (Boxes.yes_no (selinux_context_default)));
+    GLib.stdout.printf (_("â The SELinux context is default: %s\n").printf (Boxes.yes_no (selinux_context_default)));
     if (selinux_context_diagnosis.length != 0)
         GLib.stdout.printf (Boxes.indent ("    ", selinux_context_diagnosis) + "\n");
     GLib.stdout.printf ("\n");
-    GLib.stdout.printf (N_("Report bugs to <%s>.\n"), Config.PACKAGE_BUGREPORT);
-    GLib.stdout.printf (N_("%s home page: <%s>.\n"), Environment.get_application_name (), Config.PACKAGE_URL);
+    GLib.stdout.printf (_("Report bugs to <%s>.\n"), Config.PACKAGE_BUGREPORT);
+    GLib.stdout.printf (_("%s home page: <%s>.\n"), Environment.get_application_name (), Config.PACKAGE_URL);
 }
 
 public int main (string[] args) {
diff --git a/src/util.vala b/src/util.vala
index 2521437..441927f 100644
--- a/src/util.vala
+++ b/src/util.vala
@@ -276,7 +276,7 @@ namespace Boxes {
     }
 
     public string yes_no (bool value) {
-        return value ? N_("yes") : N_("no");
+        return value ? _("yes") : _("no");
     }
 
     public string indent (string space, string text) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]