[rhythmbox] playbin2: complain if we can't create an audio sink



commit 072448f6eba8a4ec394ebc2d1ce4cd148ae62181
Author: Jonathan Matthew <jonathan d14n org>
Date:   Thu Aug 23 09:04:52 2012 +1000

    playbin2: complain if we can't create an audio sink

 backends/gstreamer/rb-player-gst.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index aafcd71..f7b97ee 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -635,7 +635,8 @@ construct_pipeline (RBPlayerGst *mp, GError **error)
 		g_set_error (error,
 			     RB_PLAYER_ERROR,
 			     RB_PLAYER_ERROR_GENERAL,
-			     _("Failed to create playbin2 element; check your GStreamer installation"));
+			     _("Failed to create %s element; check your GStreamer installation"),
+			     "playbin2");
 		return FALSE;
 	}
 	g_signal_connect_object (G_OBJECT (mp->priv->playbin),
@@ -672,6 +673,14 @@ construct_pipeline (RBPlayerGst *mp, GError **error)
 				break;
 			}
 		}
+		if (mp->priv->audio_sink == NULL) {
+			g_set_error (error,
+				     RB_PLAYER_ERROR,
+				     RB_PLAYER_ERROR_GENERAL,
+				     _("Failed to create %s element; check your GStreamer installation"),
+				     "autoaudiosink");
+			return FALSE;
+		}
 	} else {
 		rb_debug ("existing audio sink found");
 		g_object_unref (mp->priv->audio_sink);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]