[gnome-shell] workspacesView: Avoid an unnecessary animation
- From: Florian MÃllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] workspacesView: Avoid an unnecessary animation
- Date: Wed, 22 Aug 2012 14:27:21 +0000 (UTC)
commit e92a6b3c6cd7bec438cb7fc87426208d3dd5cb45
Author: Florian MÃllner <fmuellner gnome org>
Date: Sun Jul 29 12:06:17 2012 +0200
workspacesView: Avoid an unnecessary animation
Currently we animate scrolling to the active workspace both when
the number of workspaces changed and after changing the active
workspace. So in case we don't actually change workspace, this
results in an unnecessary animation that may even have unwanted
side effects: when done during the overview transition (e.g. in
the case of opening and activating a window on an empty workspace),
non-active workspaces become visible during the transition.
To fix, don't scroll to the active workspace when the number of
workspaces changes and rely on the 'switch-workspace' signal being
emitted as necessary.
https://bugzilla.gnome.org/show_bug.cgi?id=682002
js/ui/workspacesView.js | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index f769186..2b5eac5 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -317,8 +317,6 @@ const WorkspacesView = new Lang.Class({
this._updateWorkspaceActors(false);
}
-
- this._scrollToActive(true);
},
_activeWorkspaceChanged: function(wm, from, to, direction) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]