[gnome-shell/wip/re-search: 11/17] remoteSearch: We do not need a fallback for createIcon



commit 6f28fd2e09413d7789f4c740d0881ed264a16ef8
Author: Tanner Doshier <doshitan gmail com>
Date:   Thu Aug 16 21:22:22 2012 -0500

    remoteSearch: We do not need a fallback for createIcon
    
    Remote providers no longer have access to a grid layout, where an icon is
    a requirement. If they don't specify an icon, don't create one.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=681797

 js/ui/remoteSearch.js |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js
index b84af54..2a375ab 100644
--- a/js/ui/remoteSearch.js
+++ b/js/ui/remoteSearch.js
@@ -124,12 +124,9 @@ const RemoteSearchProvider = new Lang.Class({
             let textureCache = St.TextureCache.get_default();
             return textureCache.load_from_raw(data, hasAlpha,
                                               width, height, rowStride, size);
+        } else {
+            return null;
         }
-
-        // Ugh, but we want to fall back to something ...
-        return new St.Icon({ icon_name: 'text-x-generic',
-                             icon_size: size,
-                             icon_type: St.IconType.FULLCOLOR });
     },
 
     _getResultsFinished: function(results, error) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]