[libgda] Misc code improvements



commit 1b886fbd39c3bb0e478325b836ba22f6c22144aa
Author: Vivien Malerba <malerba gnome-db org>
Date:   Sat Aug 18 13:00:46 2012 +0200

    Misc code improvements

 libgda/sql-parser/gda-statement-struct-compound.c |    7 +++--
 libgda/sqlite/virtual/gda-virtual-connection.c    |   24 +++++++++-----------
 2 files changed, 15 insertions(+), 16 deletions(-)
---
diff --git a/libgda/sql-parser/gda-statement-struct-compound.c b/libgda/sql-parser/gda-statement-struct-compound.c
index f09a764..119c1d4 100644
--- a/libgda/sql-parser/gda-statement-struct-compound.c
+++ b/libgda/sql-parser/gda-statement-struct-compound.c
@@ -84,9 +84,10 @@ _gda_sql_statement_compound_copy (gpointer src)
 	dest = gda_sql_statement_compound_new ();
 	dest->compound_type = compound->compound_type;
 	for (list = compound->stmt_list; list; list = list->next) {
-		dest->stmt_list = g_slist_prepend (dest->stmt_list,
-						   gda_sql_statement_copy ((GdaSqlStatement*) list->data));
-		gda_sql_any_part_set_parent (((GdaSqlStatement*) dest->stmt_list->data)->contents, dest);
+		GdaSqlStatement *sqlst;
+		sqlst = gda_sql_statement_copy ((GdaSqlStatement*) list->data);
+		gda_sql_any_part_set_parent (sqlst->contents, dest);
+		dest->stmt_list = g_slist_prepend (dest->stmt_list, sqlst);
 	}
 	dest->stmt_list = g_slist_reverse (dest->stmt_list);
 
diff --git a/libgda/sqlite/virtual/gda-virtual-connection.c b/libgda/sqlite/virtual/gda-virtual-connection.c
index 189dabd..b60b60c 100644
--- a/libgda/sqlite/virtual/gda-virtual-connection.c
+++ b/libgda/sqlite/virtual/gda-virtual-connection.c
@@ -98,24 +98,22 @@ gda_virtual_connection_get_type (void)
 
 	if (G_UNLIKELY (type == 0)) {
 		static GStaticMutex registering = G_STATIC_MUTEX_INIT;
-		if (type == 0) {
-			static GTypeInfo info = {
-				sizeof (GdaVirtualConnectionClass),
-				(GBaseInitFunc) NULL,
-				(GBaseFinalizeFunc) NULL,
-				(GClassInitFunc) gda_virtual_connection_class_init,
-				NULL, NULL,
-				sizeof (GdaVirtualConnection),
-				0,
-				(GInstanceInitFunc) gda_virtual_connection_init,
-				0
-			};
+		static GTypeInfo info = {
+			sizeof (GdaVirtualConnectionClass),
+			(GBaseInitFunc) NULL,
+			(GBaseFinalizeFunc) NULL,
+			(GClassInitFunc) gda_virtual_connection_class_init,
+			NULL, NULL,
+			sizeof (GdaVirtualConnection),
+			0,
+			(GInstanceInitFunc) gda_virtual_connection_init,
+			0
+		};
 			
 		g_static_mutex_lock (&registering);
 		if (type == 0)
 			type = g_type_register_static (PARENT_TYPE, "GdaVirtualConnection", &info, G_TYPE_FLAG_ABSTRACT);
 		g_static_mutex_unlock (&registering);
-		}
 	}
 
 	return type;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]