[libsoup] soup-socket.c: fix a use-after-free of a GCancellable



commit 1ce7f05e303cda7e53cf7d8e7797f0340e10fd14
Author: Dan Winship <danw gnome org>
Date:   Mon Aug 6 10:33:38 2012 -0400

    soup-socket.c: fix a use-after-free of a GCancellable

 libsoup/soup-socket.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
index 4369ff3..c789e64 100644
--- a/libsoup/soup-socket.c
+++ b/libsoup/soup-socket.c
@@ -670,10 +670,11 @@ socket_connected (SoupSocket *sock, GSocketConnection *conn, GError *error)
 
 	if (priv->connect_cancel) {
 		GCancellable *cancellable = priv->connect_cancel;
+		gboolean cancelled = g_cancellable_is_cancelled (cancellable);
 
 		g_object_unref (priv->connect_cancel);
 		priv->connect_cancel = NULL;
-		if (g_cancellable_is_cancelled (cancellable))
+		if (cancelled)
 			return SOUP_STATUS_CANCELLED;
 	}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]