[banshee] osx: fix muted volume on startup (bgo#660012)
- From: Bertrand Lorentz <blorentz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] osx: fix muted volume on startup (bgo#660012)
- Date: Wed, 1 Aug 2012 11:00:21 +0000 (UTC)
commit 96ee436bbf95bad7565e494555695f797f0382d0
Author: Timo DÃrr <timo latecrew de>
Date: Mon Jul 30 17:52:56 2012 +0200
osx: fix muted volume on startup (bgo#660012)
This commit fixes a bug in the libbanshee library, which did not set the
initial current_volume. As a result, the volume returned by
bp_get_volume () will always be 0 until one modifies/sets a new volume
via the volume slider.
This bug also manifests itself on Linux, but the
volume would slider get set to the right value once you start playing a
track.
Signed-off-by: Bertrand Lorentz <bertrand lorentz gmail com>
libbanshee/banshee-player-pipeline.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/libbanshee/banshee-player-pipeline.c b/libbanshee/banshee-player-pipeline.c
index dcfb4ed..ed845f3 100644
--- a/libbanshee/banshee-player-pipeline.c
+++ b/libbanshee/banshee-player-pipeline.c
@@ -360,6 +360,10 @@ _bp_pipeline_construct (BansheePlayer *player)
player->volume = gst_element_factory_make ("volume", NULL);
g_return_val_if_fail (player->volume != NULL, FALSE);
+ // call the volume changed callback once so the volume from the pipeline is
+ // set in the player object
+ bp_volume_changed_callback (player->playbin, NULL, player);
+
audiosinkqueue = gst_element_factory_make ("queue", "audiosinkqueue");
g_return_val_if_fail (audiosinkqueue != NULL, FALSE);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]