[rhythmbox] preferences: don't free consumed floating GVariant



commit 0a3cb152e031b95ecf643b05dbc6c7385116a811
Author: Ryan Lortie <desrt desrt ca>
Date:   Mon Jul 30 17:07:59 2012 +0200

    preferences: don't free consumed floating GVariant
    
    g_variant_builder_end() returns a floating reference and
    g_settings_set_value() consumes it, so we should not unref it again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680842

 shell/rb-shell-preferences.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/shell/rb-shell-preferences.c b/shell/rb-shell-preferences.c
index ecde4e2..b741cd1 100644
--- a/shell/rb-shell-preferences.c
+++ b/shell/rb-shell-preferences.c
@@ -474,7 +474,6 @@ column_check_toggled_cb (GtkWidget *widget, RBShellPreferences *preferences)
 
 	g_settings_set_value (preferences->priv->source_settings, "visible-columns", v);
 
-	g_variant_unref (v);
 	g_variant_builder_unref (b);
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]