[extensions-web] extensions: Make shell_update use GET, not POST
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] extensions: Make shell_update use GET, not POST
- Date: Tue, 24 Apr 2012 07:10:43 +0000 (UTC)
commit 088038b2360a82354ba19dce647384c2c51265a9
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Tue Apr 24 03:09:44 2012 -0400
extensions: Make shell_update use GET, not POST
If we want to access it from the Shell, we don't want CSRF protection
getting in our way. It also doesn't make sense as a POST operation.
sweettooth/extensions/tests.py | 6 ++----
sweettooth/extensions/views.py | 3 +--
2 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/sweettooth/extensions/tests.py b/sweettooth/extensions/tests.py
index 4057dc1..2e3f60e 100644
--- a/sweettooth/extensions/tests.py
+++ b/sweettooth/extensions/tests.py
@@ -478,10 +478,8 @@ class UpdateVersionTest(TestCase):
version_tag=downgrade_pk) }
def grab_response(self, installed):
- post_data = dict(installed=json.dumps(installed))
-
- response = self.client.post(reverse('extensions-shell-update'),
- post_data)
+ response = self.client.get(reverse('extensions-shell-update'),
+ dict(installed=json.dumps(installed)))
return json.loads(response.content)
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index aa066c6..3ee69cc 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -81,9 +81,8 @@ def shell_download(request, uuid):
return redirect(version.source.url)
@ajax_view
- require_POST
def shell_update(request):
- installed = json.loads(request.POST['installed'])
+ installed = json.loads(request.GET['installed'])
operations = {}
for uuid, version in installed.iteritems():
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]