[gnome-desktop] gnome-bg: Fix crash when system clock is behind start date
- From: Vincent Untz <vuntz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-desktop] gnome-bg: Fix crash when system clock is behind start date
- Date: Mon, 16 Apr 2012 15:27:31 +0000 (UTC)
commit d7cc5dadc3831b149bab1cd3e4af50e441546c2e
Author: Daniel Drake <dsd laptop org>
Date: Wed Apr 11 13:59:32 2012 -0600
gnome-bg: Fix crash when system clock is behind start date
The 1-slide background included in Fedora 17 causes a crash
in gnome-bg when the system clock is set behind the date specified
in the slideshow xml file.
This was due to slide->duration being set to UINT_MAX (to indicate a
single-slide show) but show->total_duration not being updated to take
account of this. The calculation in get_current_slide() was therefore
confused, and triggered a g_assert_not_reached().
https://bugzilla.gnome.org/show_bug.cgi?id=673551
libgnome-desktop/gnome-bg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libgnome-desktop/gnome-bg.c b/libgnome-desktop/gnome-bg.c
index c6e4e06..9a583a6 100644
--- a/libgnome-desktop/gnome-bg.c
+++ b/libgnome-desktop/gnome-bg.c
@@ -2953,7 +2953,7 @@ read_slideshow_file (const char *filename,
/* one slide, there's no transition */
} else if (len == 1) {
Slide *slide = show->slides->head->data;
- slide->duration = G_MAXUINT;
+ slide->duration = show->total_duration = G_MAXUINT;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]