[extensions-web] review: Do not auto-approve new extensions



commit bd4f6379c614aaab34820020e86c2035bd7854f4
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Apr 9 01:56:23 2012 -0300

    review: Do not auto-approve new extensions
    
    Oops

 sweettooth/review/views.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index 3353bed..2ee5279 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -399,7 +399,7 @@ def extension_submitted(sender, request, version, **kwargs):
     old_zipfile, new_zipfile = get_zipfiles(get_latest_active_version(version), version)
     changeset = get_file_changeset(old_zipfile, new_zipfile)
 
-    if safe_to_auto_approve(changeset, extension=version.extension):
+    if new_zipfile is not None and safe_to_auto_approve(changeset, extension=version.extension):
         log = ChangeStatusLog.objects.create(user=request.user,
                                              version=version,
                                              newstatus=models.STATUS_ACTIVE,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]