[glade/glade-3-12] Fixed memory leak on handler-suggestion emison
- From: Juan Pablo Ugarte <jpu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glade/glade-3-12] Fixed memory leak on handler-suggestion emison
- Date: Tue, 3 Apr 2012 19:01:23 +0000 (UTC)
commit 5ac8115fd0b47b39cb7d0f52541bf68a437d8b95
Author: Juan Pablo Ugarte <juanpablougarte gmail com>
Date: Sat Mar 31 22:59:36 2012 -0300
Fixed memory leak on handler-suggestion emison
gladeui/glade-signal-editor.c | 21 ++++++++++-----------
1 files changed, 10 insertions(+), 11 deletions(-)
---
diff --git a/gladeui/glade-signal-editor.c b/gladeui/glade-signal-editor.c
index 132f6d5..688589e 100644
--- a/gladeui/glade-signal-editor.c
+++ b/gladeui/glade-signal-editor.c
@@ -228,7 +228,6 @@ on_handler_editing_started (GtkCellRenderer *renderer,
GladeSignalEditorPrivate *priv = self->priv;
GtkEntry *entry = GTK_ENTRY (editable);
GtkEntryCompletion *completion;
- const gchar *signal_name = NULL;
GtkTreePath *tree_path;
GtkTreeIter iter;
GladeSignal *signal;
@@ -242,7 +241,6 @@ on_handler_editing_started (GtkCellRenderer *renderer,
gtk_tree_model_get (priv->model, &iter,
GLADE_SIGNAL_COLUMN_SIGNAL, &signal,
-1);
- signal_name = glade_signal_get_name (signal);
if (glade_signal_is_dummy (signal))
gtk_entry_set_text (entry, "");
@@ -251,9 +249,6 @@ on_handler_editing_started (GtkCellRenderer *renderer,
g_object_unref (signal);
- if (!signal_name)
- return;
-
completion = gtk_entry_completion_new ();
gtk_entry_completion_set_text_column (completion, 0);
gtk_entry_completion_set_minimum_key_length (completion, 0);
@@ -264,14 +259,18 @@ on_handler_editing_started (GtkCellRenderer *renderer,
gtk_list_store_clear (priv->handler_completion_store);
- for (i = 0; suggestions[i]; i++)
+ if (suggestions)
{
- gtk_list_store_append (priv->handler_completion_store, &iter);
- gtk_list_store_set (priv->handler_completion_store, &iter, 0, suggestions[i], -1);
+ for (i = 0; suggestions[i]; i++)
+ {
+ gtk_list_store_append (priv->handler_completion_store, &iter);
+ gtk_list_store_set (priv->handler_completion_store, &iter, 0, suggestions[i], -1);
+ }
+
+ gtk_entry_completion_set_model (completion, GTK_TREE_MODEL (priv->handler_completion_store));
+ gtk_entry_set_completion (entry, completion);
+ g_strfreev (suggestions);
}
-
- gtk_entry_completion_set_model (completion, GTK_TREE_MODEL (priv->handler_completion_store));
- gtk_entry_set_completion (entry, completion);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]