[cogl/cogl-1.8] pipeline: Use cogl_depth_state_init to init default depth state
- From: Neil Roberts <nroberts src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cogl/cogl-1.8] pipeline: Use cogl_depth_state_init to init default depth state
- Date: Tue, 3 Apr 2012 15:46:32 +0000 (UTC)
commit 1a325e61e6c4da3b964b7639b942536bb6092cd7
Author: Neil Roberts <neil linux intel com>
Date: Sat Mar 31 21:30:26 2012 +0100
pipeline: Use cogl_depth_state_init to init default depth state
The previous code to initialise the depth state on the default
pipeline wasn't initialising the magic number. If you later tried to
retrieve the depth state using cogl_pipeline_get_depth_state you would
end up with an invalid depth state struct and you would just get
warnings if you tried to use it for anything. This patch just replaces
the initialisation with a call to cogl_depth_state_init because it
uses the same values anyway.
Reviewed-by: Robert Bragg <robert linux intel com>
(cherry picked from commit be9d5b34c66ac81656e37779eb64891a062f90af)
cogl/cogl-depth-state.c | 1 +
cogl/cogl-pipeline.c | 8 +-------
2 files changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/cogl/cogl-depth-state.c b/cogl/cogl-depth-state.c
index 076d1b2..d441adc 100644
--- a/cogl/cogl-depth-state.c
+++ b/cogl/cogl-depth-state.c
@@ -35,6 +35,7 @@ cogl_depth_state_init (CoglDepthState *state)
{
state->magic = COGL_DEPTH_STATE_MAGIC;
+ /* The same as the GL defaults */
state->test_enabled = FALSE;
state->write_enabled = TRUE;
state->test_function = COGL_DEPTH_TEST_FUNCTION_LESS;
diff --git a/cogl/cogl-pipeline.c b/cogl/cogl-pipeline.c
index 006885c..d2dadec 100644
--- a/cogl/cogl-pipeline.c
+++ b/cogl/cogl-pipeline.c
@@ -188,7 +188,6 @@ _cogl_pipeline_init_default_pipeline (void)
CoglPipelineLightingState *lighting_state = &big_state->lighting_state;
CoglPipelineAlphaFuncState *alpha_state = &big_state->alpha_state;
CoglPipelineBlendState *blend_state = &big_state->blend_state;
- CoglDepthState *depth_state = &big_state->depth_state;
CoglPipelineLogicOpsState *logic_ops_state = &big_state->logic_ops_state;
CoglPipelineCullFaceState *cull_face_state = &big_state->cull_face_state;
@@ -287,12 +286,7 @@ _cogl_pipeline_init_default_pipeline (void)
big_state->user_program = COGL_INVALID_HANDLE;
- /* The same as the GL defaults */
- depth_state->test_enabled = FALSE;
- depth_state->test_function = COGL_DEPTH_TEST_FUNCTION_LESS;
- depth_state->write_enabled = TRUE;
- depth_state->range_near = 0;
- depth_state->range_far = 1;
+ cogl_depth_state_init (&big_state->depth_state);
big_state->point_size = 1.0f;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]