[extensions-web] review: Refactor email template code
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] review: Refactor email template code
- Date: Mon, 2 Apr 2012 04:34:44 +0000 (UTC)
commit 8d31f726f9f60b767407267d4a177c055d6b5985
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Sun Apr 1 23:00:08 2012 -0400
review: Refactor email template code
sweettooth/review/views.py | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
---
diff --git a/sweettooth/review/views.py b/sweettooth/review/views.py
index d7136f3..c26f2cd 100644
--- a/sweettooth/review/views.py
+++ b/sweettooth/review/views.py
@@ -306,6 +306,15 @@ def review_version_view(request, obj):
return render(request, 'review/review.html', context)
+def render_mail(template, data):
+ subject_template = 'review/%s_mail_subject.txt' % (template,)
+ body_template = 'review/%s_mail.txt' % (template,)
+
+ subject = render_to_string(subject_template, data, Context(autoescape=False))
+ body = render_to_string(body_template, data, Context(autoescape=False))
+
+ return subject.strip(), body.strip()
+
def send_email_on_submitted(sender, request, version, **kwargs):
extension = version.extension
@@ -316,8 +325,7 @@ def send_email_on_submitted(sender, request, version, **kwargs):
extension=extension,
url=url)
- subject = render_to_string('review/submitted_mail_subject.txt', data, Context(autoescape=False)).strip()
- body = render_to_string('review/submitted_mail.txt', data, Context(autoescape=False)).strip()
+ subject, body = render_mail('submitted', data)
recipient_list = get_all_reviewers().values_list('email', flat=True)
@@ -340,8 +348,7 @@ def send_email_on_reviewed(sender, request, version, review, **kwargs):
review=review,
url=url)
- subject = render_to_string('review/reviewed_mail_subject.txt', data, Context(autoescape=False)).strip()
- body = render_to_string('review/reviewed_mail.txt', data, Context(autoescape=False)).strip()
+ subject, body = render_mail('reviewed', data)
recipient_list = list(version.reviews.values_list('reviewer__email', flat=True).distinct())
recipient_list.append(extension.creator.email)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]