[extensions-web] Don't recreate the file view on every switch.



commit 58bef3d4b45b63968e84c0fdba954960daeb05fe
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Sep 27 15:30:17 2011 -0400

    Don't recreate the file view on every switch.

 sweettooth/static/js/review.js |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/sweettooth/static/js/review.js b/sweettooth/static/js/review.js
index cb390a4..c16151b 100644
--- a/sweettooth/static/js/review.js
+++ b/sweettooth/static/js/review.js
@@ -44,12 +44,15 @@ define(['jquery'], function($) {
             $.each(data, function() {
                 var data = this;
                 var $selector = $('<a>', {'class': 'fileselector'}).text(data.filename);
+                var $file = null;
 
                 $selector.click(function() {
                     if ($selector.hasClass('selected'))
                         return;
 
-                    var $file = createFileView(data).hide().appendTo($fileDisplay);
+                    if ($file === null)
+                        $file = createFileView(data).hide().appendTo($fileDisplay);
+
                     $fileList.find('li a.fileselector').removeClass('selected');
                     $selector.addClass('selected');
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]