[clutter-gst] Add "-Wsign-compare" to the maintainer flags and fix the resulting warnings

[Thomas Wood <thos src gnome org>]

commit f92a80288a57cc0fbc58a74e3a143b7318649557
Author: Thomas Wood <thomas wood intel com>
Date:   Wed Sep 21 13:39:29 2011 +0100

    Add "-Wsign-compare" to the maintainer flags and fix the resulting warnings

 clutter-gst/clutter-gst-player.c     |    6 +++---
 clutter-gst/clutter-gst-video-sink.c |    6 +++---
 configure.ac                         |    2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/clutter-gst/clutter-gst-player.c b/clutter-gst/clutter-gst-player.c
index cfbbbf1..2265137 100644
--- a/clutter-gst/clutter-gst-player.c
+++ b/clutter-gst/clutter-gst-player.c
@@ -1023,7 +1023,7 @@ bus_message_duration_cb (GstBus           *bus,
   /* GstElements send a duration message on the bus with GST_CLOCK_TIME_NONE
    * as duration to signal a new duration */
   gst_message_parse_duration (message, NULL, &duration);
-  if (G_UNLIKELY (duration != GST_CLOCK_TIME_NONE))
+  if (G_UNLIKELY ((GstClockTime) duration != GST_CLOCK_TIME_NONE))
     return;
 
   query_duration (player);
@@ -2201,7 +2201,7 @@ clutter_gst_player_set_audio_stream (ClutterGstPlayer *player,
   priv = PLAYER_GET_PRIVATE (player);
 
   g_return_if_fail (index_ >= 0 &&
-                    index_ < g_list_length (priv->audio_streams));
+                    index_ < (gint) g_list_length (priv->audio_streams));
 
   CLUTTER_GST_NOTE (AUDIO_STREAM, "set audio audio stream to #%d", index_);
 
@@ -2298,7 +2298,7 @@ clutter_gst_player_set_subtitle_track (ClutterGstPlayer *player,
   priv = PLAYER_GET_PRIVATE (player);
 
   g_return_if_fail (index_ >= -1 &&
-                    index_ < g_list_length (priv->subtitle_tracks));
+                    index_ < (gint) g_list_length (priv->subtitle_tracks));
 
   CLUTTER_GST_NOTE (SUBTITLES, "set subtitle track to #%d", index_);
 
diff --git a/clutter-gst/clutter-gst-video-sink.c b/clutter-gst/clutter-gst-video-sink.c
index f2c79e5..3246693 100644
--- a/clutter-gst/clutter-gst-video-sink.c
+++ b/clutter-gst/clutter-gst-video-sink.c
@@ -998,7 +998,7 @@ clutter_gst_video_sink_set_caps (GstBaseSink *bsink,
   const GValue               *par;
   gint                        width, height;
   guint32                     fourcc;
-  int                         red_mask, blue_mask;
+  guint                       red_mask, blue_mask;
 
   sink = CLUTTER_GST_VIDEO_SINK(bsink);
   priv = sink->priv;
@@ -1064,8 +1064,8 @@ clutter_gst_video_sink_set_caps (GstBaseSink *bsink,
   else
     {
       guint32 mask;
-      gst_structure_get_int (structure, "red_mask", &red_mask);
-      gst_structure_get_int (structure, "blue_mask", &blue_mask);
+      gst_structure_get_uint (structure, "red_mask", &red_mask);
+      gst_structure_get_uint (structure, "blue_mask", &blue_mask);
 
       mask = red_mask | blue_mask;
       if (mask < 0x1000000)
diff --git a/configure.ac b/configure.ac
index f8700ab..1fafe5e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -182,7 +182,7 @@ AS_IF([test "x$enable_maintainer_flags" = "xyes" && test "x$GCC" = "xyes"],
         AS_COMPILER_FLAGS([MAINTAINER_CFLAGS],
                           ["-Wall -Wshadow -Wcast-align -Wno-uninitialized
                             -Wno-strict-aliasing -Wempty-body -Wformat-security
-                            -Winit-self"])
+                            -Winit-self -Wsign-compare"])
       ]
 )