[clutter] actor: consider empty pv ok in set_default_paint_volume
- From: Robert Bragg <rbragg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [clutter] actor: consider empty pv ok in set_default_paint_volume
- Date: Mon, 19 Sep 2011 16:00:36 +0000 (UTC)
commit 96866804f05b24d35fbb2f93c00aaeb075f25c4f
Author: Robert Bragg <robert linux intel com>
Date: Mon Sep 19 14:38:08 2011 +0100
actor: consider empty pv ok in set_default_paint_volume
In _clutter_actor_set_default_paint_volume we were returning FALSE if an
actor has an empty allocation because we were claiming it doesn't have a
paint-volume. Actually an empty/degenerate pv is valid and has different
semantics to returning FALSE because FALSE means the pv is unknown and
so Clutter will have to assume the worst - that the pv is basically
un-bounded.
Reviewed-by: Emmanuele Bassi <ebassi linux intel com>
clutter/clutter-paint-volume.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/clutter/clutter-paint-volume.c b/clutter/clutter-paint-volume.c
index 24ea8da..7514c13 100644
--- a/clutter/clutter-paint-volume.c
+++ b/clutter/clutter-paint-volume.c
@@ -967,10 +967,6 @@ _clutter_actor_set_default_paint_volume (ClutterActor *self,
clutter_actor_get_allocation_box (self, &box);
- /* a zero-sized actor has no paint volume */
- if (box.x1 == box.x2 || box.y1 == box.y2)
- return FALSE;
-
clutter_paint_volume_set_width (volume, box.x2 - box.x1);
clutter_paint_volume_set_height (volume, box.y2 - box.y1);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]