[empathy] AccountChooser: don't return garbage from _set_account
- From: Will Thompson <wjt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [empathy] AccountChooser: don't return garbage from _set_account
- Date: Tue, 13 Sep 2011 13:18:11 +0000 (UTC)
commit 0a3f996d2ec2eed860edda7c36a9b6bdbd9d2722
Author: Will Thompson <will thompson collabora co uk>
Date: Fri Sep 9 15:28:42 2011 +0100
AccountChooser: don't return garbage from _set_account
Previously, the 'set' field of the stack-allocated 'data' structure was
not initialized. It's explicitly set to TRUE if the account is found,
but never otherwise set; so if the account is not found, this function
returned random garbage.
Reviewed-by: Xavier Claessens <xclaesse gmail com>
libempathy-gtk/empathy-account-chooser.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/libempathy-gtk/empathy-account-chooser.c b/libempathy-gtk/empathy-account-chooser.c
index cb9028c..c16f9c7 100644
--- a/libempathy-gtk/empathy-account-chooser.c
+++ b/libempathy-gtk/empathy-account-chooser.c
@@ -428,6 +428,7 @@ empathy_account_chooser_set_account (EmpathyAccountChooser *chooser,
data.chooser = chooser;
data.account = account;
+ data.set = FALSE;
gtk_tree_model_foreach (model,
(GtkTreeModelForeachFunc) account_chooser_set_account_foreach,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]