[evolution-ews/gnome-2-28] Bug 713635 - [EWS] evolution-data-server crashes when dragging an event in offline (bnc)
- From: Chenthill Palanisamy <pchen src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-ews/gnome-2-28] Bug 713635 - [EWS] evolution-data-server crashes when dragging an event in offline (bnc)
- Date: Mon, 12 Sep 2011 06:59:43 +0000 (UTC)
commit 6ac25b2cf1ffbc842f35cc9314deeac4e943b7fd
Author: Chenthill Palanisamy <pchenthill novell com>
Date: Mon Sep 12 06:55:04 2011 +0530
Bug 713635 - [EWS] evolution-data-server crashes when dragging an event in offline (bnc)
src/calendar/e-cal-backend-ews.c | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
---
diff --git a/src/calendar/e-cal-backend-ews.c b/src/calendar/e-cal-backend-ews.c
index 32118ae..706741e 100644
--- a/src/calendar/e-cal-backend-ews.c
+++ b/src/calendar/e-cal-backend-ews.c
@@ -597,7 +597,6 @@ e_cal_backend_ews_get_default_object (ECalBackend *backend, EDataCal *cal)
exit:
e_data_cal_notify_default_object (cal, EDC_ER_CODE(error), object);
- g_clear_error (&error);
g_free (object);
}
@@ -2143,8 +2142,12 @@ e_cal_backend_ews_modify_object (ECalBackend *backend, EDataCal *cal,
attach_data->itemid = itemid;
attach_data->changekey = changekey;
- if (cal)
+ if (cal) {
+ if (error)
+ g_warning ("Modify object error : %s\n", error->message);
e_data_cal_notify_object_modified (cal, EDC_ER_CODE (error), NULL, NULL);
+ error = NULL;
+ }
e_ews_connection_create_attachments_start (priv->cnc, EWS_PRIORITY_MEDIUM,
item_id, added_attachments,
@@ -2183,12 +2186,13 @@ e_cal_backend_ews_modify_object (ECalBackend *backend, EDataCal *cal,
return;
exit:
+ if (error)
+ g_warning ("Modify object error : %s\n", error->message);
+
if (cal)
e_data_cal_notify_object_modified (cal, EDC_ER_CODE(error), NULL, NULL);
- if (error) {
- g_warning ("Modify object error : %s\n", error->message);
+ else
g_clear_error (&error);
- }
}
typedef struct {
@@ -3220,13 +3224,11 @@ ews_cal_sync_items_ready_cb (GObject *obj, GAsyncResult *res, gpointer user_data
PRIV_UNLOCK (priv);
if (error != NULL) {
- g_warning ("Unable to Sync changes %s \n", error->message);
+ g_warning ("Unable to Sync changes \n");
PRIV_LOCK (priv);
priv->refreshing = FALSE;
PRIV_UNLOCK (priv);
-
- g_clear_error (&error);
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]