[gnome-subtitles] Added TODOs with warnings to show related to bug #653677



commit bfea5719ba63f8c06e54e0b59e1d10ae56935096
Author: Pedro Castro <pedro gnomesubtitles org>
Date:   Sun Sep 11 22:27:46 2011 +0100

    Added TODOs with warnings to show related to bug #653677

 .../SubtitleFormatAdobeEncoreDVD.cs                |    1 +
 .../SubtitleFormatAdvancedSubStationAlpha.cs       |    3 ++-
 .../SubtitleFormatKaraokeLyricsLRC.cs              |    3 ++-
 .../SubtitleFormatKaraokeLyricsVKT.cs              |    3 ++-
 .../IO/SubtitleFormats/SubtitleFormatMPSub.cs      |    1 +
 5 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdobeEncoreDVD.cs b/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdobeEncoreDVD.cs
index 4f94d7a..cf1c023 100644
--- a/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdobeEncoreDVD.cs
+++ b/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdobeEncoreDVD.cs
@@ -24,6 +24,7 @@ using System.Text.RegularExpressions;
 
 namespace SubLib.IO.SubtitleFormats {
 
+//TODO: warn when saving files with a framerate different than 25 or 29,97.
 internal class SubtitleFormatAdobeEncoreDVD : SubtitleFormat {
 	private Regex inputRegexPAL = new Regex(@"\d+(\s*:\s*\d+){3}\s+\d+(\s*:\s*\d+){3}\s*.+");
 	
diff --git a/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdvancedSubStationAlpha.cs b/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdvancedSubStationAlpha.cs
index 67a4aa3..103e00f 100644
--- a/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdvancedSubStationAlpha.cs
+++ b/src/SubLib/IO/SubtitleFormats/SubtitleFormatAdvancedSubStationAlpha.cs
@@ -22,7 +22,8 @@ using System;
 using System.Text.RegularExpressions;
 
 namespace SubLib.IO.SubtitleFormats {
-
+
+//TODO: check when hours >= 10 (2+ digits)
 internal class SubtitleFormatAdvancedSubStationAlpha : SubtitleFormatSubStationAlpha {
 	
 	protected override string FormatName {
diff --git a/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsLRC.cs b/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsLRC.cs
index 775ed44..990e0b0 100644
--- a/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsLRC.cs
+++ b/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsLRC.cs
@@ -22,7 +22,8 @@ using System;
 using System.Text.RegularExpressions;
 
 namespace SubLib.IO.SubtitleFormats {
-	
+
+//TODO: warn when saving subtitles with times > 99 minutes, warn when saving with 2+ lines
 internal class SubtitleFormatKaraokeLyricsLRC : SubtitleFormat {
 		
 	internal SubtitleFormatKaraokeLyricsLRC() {
diff --git a/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsVKT.cs b/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsVKT.cs
index bf81615..2eb269d 100644
--- a/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsVKT.cs
+++ b/src/SubLib/IO/SubtitleFormats/SubtitleFormatKaraokeLyricsVKT.cs
@@ -22,7 +22,8 @@ using System;
 using System.Text.RegularExpressions;
 
 namespace SubLib.IO.SubtitleFormats {
-	
+
+//TODO: warn when saving with 2+ lines
 internal class SubtitleFormatKaraokeLyricsVKT : SubtitleFormat {
 		
 	internal SubtitleFormatKaraokeLyricsVKT() {
diff --git a/src/SubLib/IO/SubtitleFormats/SubtitleFormatMPSub.cs b/src/SubLib/IO/SubtitleFormats/SubtitleFormatMPSub.cs
index 2a51150..73f02e5 100644
--- a/src/SubLib/IO/SubtitleFormats/SubtitleFormatMPSub.cs
+++ b/src/SubLib/IO/SubtitleFormats/SubtitleFormatMPSub.cs
@@ -22,6 +22,7 @@ using System;
 
 namespace SubLib.IO.SubtitleFormats {
 
+//TODO: warn when opening files with comments, warn when saving lines with '#' as they will be ignored/treated as comments
 internal class SubtitleFormatMPSub : SubtitleFormat {
 	
 	internal SubtitleFormatMPSub () {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]