[tracker/experiment-with-roi] libtracker-extract: Remove where and uri args from tracker_xmp_apply_regions()

[Martyn James Russell <mr src gnome org>]

commit bb4af51550d4ec53ea6a5b682ba265384b66a285
Author: Martyn Russell <martyn lanedo com>
Date:   Wed Sep 7 10:08:32 2011 +0100

    libtracker-extract: Remove where and uri args from tracker_xmp_apply_regions()
    
    These were unused.
    
    Also documented the function to explain where it's used compared to
    tracker_xmp_apply().

 src/libtracker-extract/tracker-xmp.c       |   37 ++++++++++++++++++++++-----
 src/libtracker-extract/tracker-xmp.h       |    2 -
 src/tracker-extract/tracker-extract-jpeg.c |    2 +-
 src/tracker-extract/tracker-extract-pdf.c  |    2 +-
 src/tracker-extract/tracker-extract-tiff.c |    2 +-
 5 files changed, 33 insertions(+), 12 deletions(-)
---
diff --git a/src/libtracker-extract/tracker-xmp.c b/src/libtracker-extract/tracker-xmp.c
index 3db3c2f..4170b69 100644
--- a/src/libtracker-extract/tracker-xmp.c
+++ b/src/libtracker-extract/tracker-xmp.c
@@ -835,8 +835,8 @@ tracker_xmp_free (TrackerXmpData *data)
  * tracker_xmp_apply:
  * @preupdate: the preupdate object to apply XMP data to.
  * @metadata: the metadata object to apply XMP data to.
- * @graph: the graph to apply XMP data to
- * @where: the where object
+ * @graph: the graph to apply XMP data to.
+ * @where: the where object.
  * @uri: the URI this is related to.
  * @data: the data to push into @metadata.
  *
@@ -844,6 +844,9 @@ tracker_xmp_free (TrackerXmpData *data)
  *
  * The @graph parameter was added in 0.12.
  *
+ * This function also calls tracker_xmp_apply_regions(), so there is
+ * no need to call both functions.
+ *
  * Returns: %TRUE if the @data was applied to @metadata successfully,
  * otherwise %FALSE is returned.
  *
@@ -1179,25 +1182,45 @@ tracker_xmp_apply (TrackerSparqlBuilder *preupdate,
 
 
         if (data->regions) {
-	        tracker_xmp_apply_regions (preupdate, metadata, graph, where, uri, data);
+	        tracker_xmp_apply_regions (preupdate, metadata, graph, data);
         }
 
 	return TRUE;
 }
 
+/**
+ * tracker_xmp_apply_regions:
+ * @preupdate: the preupdate object to apply XMP data to.
+ * @metadata: the metadata object to apply XMP data to.
+ * @graph: the graph to apply XMP data to.
+ * @data: the data to push into @preupdate and @metadata.
+ *
+ * This function applies all regional @data to @preupdate and
+ * @metadata. Regional data exists for image formats like JPEG, PNG,
+ * etc. where parts of the image refer to areas of interest. This can
+ * be people's faces, places to focus, barcodes, etc. The regional
+ * data describes the title, height, width, X, Y and can occur
+ * multiple times in a given file.
+ *
+ * This data usually is standardized between image formats and that's
+ * what makes this function different to tracker_xmp_apply() which is
+ * useful for XMP files only.
+ *
+ * Returns: %TRUE if the @data was applied to @preupdate and @metadata
+ * successfully, otherwise %FALSE is returned.
+ *
+ * Since: 0.12
+ **/
 gboolean
 tracker_xmp_apply_regions (TrackerSparqlBuilder *preupdate,
                            TrackerSparqlBuilder *metadata,
                            const gchar          *graph,
-                           GString              *where,
-                           const gchar          *uri,
                            TrackerXmpData       *data)
 {
         GSList *iter;
 
         g_return_val_if_fail (TRACKER_SPARQL_IS_BUILDER (preupdate), FALSE);
-        g_return_val_if_fail (TRACKER_SPARQL_IS_BUILDER (preupdate), FALSE);
-        g_return_val_if_fail (uri != NULL, FALSE);
+        g_return_val_if_fail (TRACKER_SPARQL_IS_BUILDER (metadata), FALSE);
         g_return_val_if_fail (data != NULL, FALSE);
 
         if (!data->regions) {
diff --git a/src/libtracker-extract/tracker-xmp.h b/src/libtracker-extract/tracker-xmp.h
index 2703a99..5029021 100644
--- a/src/libtracker-extract/tracker-xmp.h
+++ b/src/libtracker-extract/tracker-xmp.h
@@ -119,8 +119,6 @@ gboolean        tracker_xmp_apply         (TrackerSparqlBuilder *preupdate,
 gboolean        tracker_xmp_apply_regions (TrackerSparqlBuilder *preupdate,
                                            TrackerSparqlBuilder *metadata,
                                            const gchar          *graph,
-                                           GString              *where,
-                                           const gchar          *uri,
                                            TrackerXmpData       *data);
 
 #ifndef TRACKER_DISABLE_DEPRECATED
diff --git a/src/tracker-extract/tracker-extract-jpeg.c b/src/tracker-extract/tracker-extract-jpeg.c
index e25dc84..45f78dd 100644
--- a/src/tracker-extract/tracker-extract-jpeg.c
+++ b/src/tracker-extract/tracker-extract-jpeg.c
@@ -435,7 +435,7 @@ tracker_extract_get_metadata (TrackerExtractInfo *info)
 	}
 
         if (xd->regions) {
-	        tracker_xmp_apply_regions (preupdate, metadata, graph, where, uri, xd);
+	        tracker_xmp_apply_regions (preupdate, metadata, graph, xd);
         }
 
 	if (id->keywords) {
diff --git a/src/tracker-extract/tracker-extract-pdf.c b/src/tracker-extract/tracker-extract-pdf.c
index c762329..e9a51a9 100644
--- a/src/tracker-extract/tracker-extract-pdf.c
+++ b/src/tracker-extract/tracker-extract-pdf.c
@@ -599,7 +599,7 @@ tracker_extract_get_metadata (TrackerExtractInfo *info)
 		}
 
                 if (xd->regions) {
-	                tracker_xmp_apply_regions (preupdate, metadata, graph, NULL, uri, xd);
+	                tracker_xmp_apply_regions (preupdate, metadata, graph, xd);
                 }
 
 		tracker_xmp_free (xd);
diff --git a/src/tracker-extract/tracker-extract-tiff.c b/src/tracker-extract/tracker-extract-tiff.c
index a95b1d3..603e239 100644
--- a/src/tracker-extract/tracker-extract-tiff.c
+++ b/src/tracker-extract/tracker-extract-tiff.c
@@ -487,7 +487,7 @@ tracker_extract_get_metadata (TrackerExtractInfo *info)
 	}
 
         if (xd->regions) {
-	        tracker_xmp_apply_regions (preupdate, metadata, graph, NULL, uri, xd);
+	        tracker_xmp_apply_regions (preupdate, metadata, graph, xd);
         }
 
 	if (md.address || md.state || md.country || md.city ||