[gnumeric] Fix graph editor crash. [#658223]
- From: Andreas J. Guelzow <guelzow src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] Fix graph editor crash. [#658223]
- Date: Tue, 6 Sep 2011 14:44:30 +0000 (UTC)
commit 6a00d4d3588d67b7bc22c7bde9c46c2243bf2aae
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date: Tue Sep 6 08:43:39 2011 -0600
Fix graph editor crash. [#658223]
2011-09-06 Andreas J. Guelzow <aguelzow pyrshep ca>
* src/wbc-gtk.c (cb_graph_dim_editor_update): don't create an infinite
signal recursion by using start_sel=FALSE in gnm_expr_entry_parse call.
ChangeLog | 5 +++++
NEWS | 1 +
src/wbc-gtk.c | 4 +++-
3 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 856f2d9..7965cf0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-09-06 Andreas J. Guelzow <aguelzow pyrshep ca>
+
+ * src/wbc-gtk.c (cb_graph_dim_editor_update): don't create an infinite
+ signal recursion by using start_sel=FALSE in gnm_expr_entry_parse call.
+
2011-09-05 Morten Welinder <terra gnome org>
* src/collect.c (collect_float_pairs): Set return variables even
diff --git a/NEWS b/NEWS
index be5e14f..11df60e 100644
--- a/NEWS
+++ b/NEWS
@@ -18,6 +18,7 @@ Andreas:
* Persist selection and edit positions through ODF files. [#657506]
* Some more number formatting improvements to ODF import/export.
* Read and write tick spacing from/to ODF files.
+ * Fix graph editor crash. [#658223]
Jean:
* Make things build against gtk+-3.0.
diff --git a/src/wbc-gtk.c b/src/wbc-gtk.c
index f14140e..9982f93 100644
--- a/src/wbc-gtk.c
+++ b/src/wbc-gtk.c
@@ -5454,9 +5454,11 @@ cb_graph_dim_editor_update (GnmExprEntry *gee,
GNM_EXPR_PARSE_UNKNOWN_NAMES_ARE_STRINGS;
parse_error_init (&perr);
+ /* Setting start_sel=FALSE to avoid */
+ /* https://bugzilla.gnome.org/show_bug.cgi?id=658223 */
texpr = gnm_expr_entry_parse (editor->entry,
parse_pos_init_sheet (&pos, sheet),
- &perr, TRUE, flags);
+ &perr, FALSE, flags);
/* TODO : add some error dialogs split out
* the code in workbook_edit to add parens. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]