[yelp] Fix crash due to access after free



commit 06dc5defbd2abea0b631d696854254fcde3211aa
Author: Edward Sheldrake <ejsheldrake gmail com>
Date:   Tue Aug 30 20:56:54 2011 +0100

    Fix crash due to access after free
    
    "next" may point to somewhere inside "url".

 libyelp/yelp-info-parser.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/libyelp/yelp-info-parser.c b/libyelp/yelp-info-parser.c
index 5ecdc5a..e16b6be 100644
--- a/libyelp/yelp-info-parser.c
+++ b/libyelp/yelp-info-parser.c
@@ -1416,12 +1416,13 @@ info_process_text_notes (xmlNodePtr *node, gchar *content, GtkTreeStore *tree)
         /* Massive space.  Fix. */
         gchar *next = break_point;
         gchar *url_copy;
+        gchar *old = url;
         while (*next == ' ')
           next++;
         next--;
         url_copy = g_strndup (url, break_point-url);
-        g_free (url);
         url = g_strconcat (url_copy, next, NULL);
+        g_free (old);
         break_point = strchr (url, ' ');
         g_free (url_copy);
       } else {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]