[dconf] Drop a dead variable
- From: Ryan Lortie <ryanl src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dconf] Drop a dead variable
- Date: Mon, 31 Oct 2011 23:18:13 +0000 (UTC)
commit a271dacba8eb0057455ed1d51304a983279b67e2
Author: Matthias Clasen <mclasen redhat com>
Date: Wed Oct 19 20:27:55 2011 -0400
Drop a dead variable
The GError in add_match_done is never used. Whats worse,
it is dereferenced in the error path.
https://bugzilla.gnome.org/show_bug.cgi?id=662259
dbus-1/dconf-dbus-1.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/dbus-1/dconf-dbus-1.c b/dbus-1/dconf-dbus-1.c
index 421ea12..abf529d 100644
--- a/dbus-1/dconf-dbus-1.c
+++ b/dbus-1/dconf-dbus-1.c
@@ -534,7 +534,6 @@ add_match_done (DBusPendingCall *pending,
gpointer user_data)
{
Watch *watch = user_data;
- GError *error = NULL;
GVariant *reply;
reply = dconf_dbus_client_send_finish (pending);
@@ -547,9 +546,7 @@ add_match_done (DBusPendingCall *pending,
* watch structure in the list).
*/
- g_critical ("DBus AddMatch for dconf path '%s': %s",
- watch->name, error->message);
- g_error_free (error);
+ g_critical ("DBus AddMatch for dconf path '%s'", watch->name);
watch_unref (watch);
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]