[extensions-web] Fix "Undo?" on uninstall.



commit b20d572e76fc51664b4398cc2cbd5cd366a70476
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Oct 31 15:32:25 2011 -0400

    Fix "Undo?" on uninstall.

 sweettooth/static/js/extensions.js |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/sweettooth/static/js/extensions.js b/sweettooth/static/js/extensions.js
index 79b424f..f155c9b 100644
--- a/sweettooth/static/js/extensions.js
+++ b/sweettooth/static/js/extensions.js
@@ -90,7 +90,8 @@ function($, messages, dbusProxy) {
 
         $elem.data({'elem': $elem,
                     'state': _state,
-                    'uninstalled': false});
+                    'uninstalled': false,
+                    'undo-uninstall-message': null});
 
         $switch.data('elem', $elem);
         $switch.switchify();
@@ -137,6 +138,7 @@ function($, messages, dbusProxy) {
                                               newState == ExtensionState.OUT_OF_DATE)) {
                 $elem.fadeIn({ queue: false }).slideDown();
                 $elem.data('uninstalled', false);
+                $elem.data('undo-uninstall-message').slideUp();
             }
 
         });
@@ -167,8 +169,6 @@ function($, messages, dbusProxy) {
                         // installed it by reattaching the element, but we can't do
                         // that here -- the user might click "Cancel".
                         $elem.data('uninstalled', true);
-
-                        message.slideUp();
                     }
 
                     function uninstall() {
@@ -183,9 +183,9 @@ function($, messages, dbusProxy) {
                                     append(". ").
                                     append($('<a>', {'href': '#'}).text("Undo?")).html();
 
-                                var message = messages.addInfo(messageHTML);
-                                message.find('a').click(reinstall);
-                                $elem.data('undo-uninstall-message', message);
+                                var $message = messages.addInfo(messageHTML);
+                                $message.find('a').click(reinstall);
+                                $elem.data('undo-uninstall-message', $message);
                             }
                         });
                     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]