[sound-juicer] sj-metadata_getter: don't leak metadata object
- From: Ross Burton <rburton src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [sound-juicer] sj-metadata_getter: don't leak metadata object
- Date: Mon, 31 Oct 2011 14:36:51 +0000 (UTC)
commit bcef8ec26548a0318d073e800c93c23f1dc70b7e
Author: Christophe Fergeau <cfergeau redhat com>
Date: Mon Aug 1 13:58:39 2011 +0200
sj-metadata_getter: don't leak metadata object
We create a SjMetadata object in lookup_cd, and when we decide to
emit a signal, we don't unref it, so we don't need to add an
additional reference to it, otherwise we'll be leaking the object.
libjuicer/sj-metadata-getter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libjuicer/sj-metadata-getter.c b/libjuicer/sj-metadata-getter.c
index 0ae49b3..1aff2f5 100644
--- a/libjuicer/sj-metadata-getter.c
+++ b/libjuicer/sj-metadata-getter.c
@@ -209,7 +209,7 @@ lookup_cd (SjMetadataGetter *mdg)
signal = g_new0 (SjMetadataGetterSignal, 1);
signal->albums = albums;
signal->mdg = g_object_ref (mdg);
- signal->metadata = g_object_ref (metadata);
+ signal->metadata = metadata;
g_idle_add ((GSourceFunc)fire_signal_idle, signal);
break;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]