[extensions-web] {% with foo=bar %} is a 1.3-ism



commit ef29d162d41fcf443d85a8929b0e240f06c2615c
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Wed Oct 19 17:16:46 2011 -0400

    {% with foo=bar %} is a 1.3-ism

 .../extensions/templates/extensions/detail.html    |    2 --
 .../extensions/templates/extensions/list.html      |    2 +-
 sweettooth/review/templates/review/list.html       |    4 ++--
 sweettooth/review/templates/review/review.html     |    2 --
 4 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/sweettooth/extensions/templates/extensions/detail.html b/sweettooth/extensions/templates/extensions/detail.html
index 14108a0..c9b57e1 100644
--- a/sweettooth/extensions/templates/extensions/detail.html
+++ b/sweettooth/extensions/templates/extensions/detail.html
@@ -22,7 +22,6 @@
 {% block extra-body-header %}
 {% endblock %}
 
-{% with extension=version.extension %}
     <div class="extension"
          data-uuid="{{ extension.uuid }}"
          data-sv="{{ version.shell_versions_json }}"
@@ -72,7 +71,6 @@
       {% block extra %}
       {% endblock %}
 </div>
-{% endwith %}
 {% endblock %}
 {% block document-ready %}{{ block.super }}
     require(['jquery.rating', 'extensions'], function() {
diff --git a/sweettooth/extensions/templates/extensions/list.html b/sweettooth/extensions/templates/extensions/list.html
index 7c570bc..326cea4 100644
--- a/sweettooth/extensions/templates/extensions/list.html
+++ b/sweettooth/extensions/templates/extensions/list.html
@@ -2,7 +2,7 @@
 {% block body %}
   <ul class="extensions">
   {% for extension in extension_list %}
-  {% with version=extension.latest_version %}
+  {% with extension.latest_version as version %}
     <li class="extension">
       {% if extension.icon %}
       <img src="{{ extension.icon.url }}" class="icon">
diff --git a/sweettooth/review/templates/review/list.html b/sweettooth/review/templates/review/list.html
index a74586b..d821c51 100644
--- a/sweettooth/review/templates/review/list.html
+++ b/sweettooth/review/templates/review/list.html
@@ -5,8 +5,8 @@
 {% block body %}
 <h2> Unreviewed Extensions </h2>
 <ul class="extensions">
-{% for version in versions %}
-{% with extension=version.extension %}
+{% for version in version_list %}
+{% with version.extension as extension %}
 <li class="extension">
   <div class="switch insensitive"></div>
 
diff --git a/sweettooth/review/templates/review/review.html b/sweettooth/review/templates/review/review.html
index f086a3e..d7ffb99 100644
--- a/sweettooth/review/templates/review/review.html
+++ b/sweettooth/review/templates/review/review.html
@@ -4,7 +4,6 @@
 {% block title %}Review "{{ version.extension.name }}" - {{ block.super }}{% endblock %}
 
 {% block body %}
-{% with extension=version.extension %}
 <h2 class="expanded"> Details Page Preview </h2>
 <div id="preview">
   <div class="extension">
@@ -79,7 +78,6 @@
 {% block extra %}
 {% endblock %}
 
-{% endwith %}
 {% endblock %}
 
 {% block document-ready %}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]