[glom] Updated a TODO
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] Updated a TODO
- Date: Mon, 10 Oct 2011 21:05:04 +0000 (UTC)
commit 8e3bc77e3f94b4732c9194871ac69904ce55abe3
Author: Murray Cumming <murrayc murrayc com>
Date: Mon Oct 10 23:04:57 2011 +0200
Updated a TODO
glom/mode_data/datawidget/treemodel_db.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/glom/mode_data/datawidget/treemodel_db.cc b/glom/mode_data/datawidget/treemodel_db.cc
index c8bfb01..2e94c75 100644
--- a/glom/mode_data/datawidget/treemodel_db.cc
+++ b/glom/mode_data/datawidget/treemodel_db.cc
@@ -67,9 +67,10 @@ void DbTreeModelRow::fill_values_if_necessary(DbTreeModel& model, int row)
const int cols_count = model.m_data_model_columns_count;
for(int i = 0; i < cols_count; ++i)
{
+ //TODO: Use iter->get_value_at(i) with try/catch instead when we can depend on libgdamm >= 4.99.4.2
Glib::RefPtr<const Gnome::Gda::Holder> holder = iter->get_holder_for_field(i);
if(holder)
- m_db_values[i] = holder->get_value(); //TODO_gda: Why not just use get_value_at()?
+ m_db_values[i] = holder->get_value();
else
{
// This is quite possible, for example for unset dates. jhs
@@ -79,6 +80,7 @@ void DbTreeModelRow::fill_values_if_necessary(DbTreeModel& model, int row)
//std::cout << " debug: col=" << i << ", GType=" << m_db_values[i].get_value_type() << ", string=" << m_db_values[i].to_string() << std::endl;
}
+ //TODO: Use iter->get_value_at(i) with try/catch instead when we can depend on libgdamm >= 4.99.4.2
Glib::RefPtr<const Gnome::Gda::Holder> holder = iter->get_holder_for_field(model.m_column_index_key);
if(holder)
m_key = holder->get_value(); //TODO_gda: Why not just use get_value_at()?
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]