[gimp/metadata-browser] Use dc:subject to store keyword properties.



commit 0e4ca52ae5f840d0a84723d408d8d48ac4567e2a
Author: Roman Joost <roman bromeco de>
Date:   Sat Oct 1 13:26:47 2011 +1000

    Use dc:subject to store keyword properties.
    
    Currently we're using a text widget. Perhaps a tag widget is more
    suitable to enter keywords.

 plug-ins/metadata/interface.c          |    4 ++--
 plug-ins/metadata/tests/files/test.xmp |    9 ++++++++-
 plug-ins/metadata/xmp-encode.c         |    9 +++++++--
 3 files changed, 17 insertions(+), 5 deletions(-)
---
diff --git a/plug-ins/metadata/interface.c b/plug-ins/metadata/interface.c
index 7c850de..f193e32 100644
--- a/plug-ins/metadata/interface.c
+++ b/plug-ins/metadata/interface.c
@@ -263,8 +263,8 @@ add_description_tab (GtkWidget   *notebook,
           GTK_POLICY_AUTOMATIC,
           GTK_POLICY_AUTOMATIC);
   text_view = g_object_new (GIMP_TYPE_XMP_MODEL_TEXT,
-                            "schema-uri", XMP_SCHEMA_PDF,
-                            "property-name", "Keywords",
+                            "schema-uri", XMP_SCHEMA_DUBLIN_CORE,
+                            "property-name", "subject",
                             "xmp-model", mgui->xmp_model,
                             NULL);
   gtk_container_add (GTK_CONTAINER (scrolled_window), text_view);
diff --git a/plug-ins/metadata/tests/files/test.xmp b/plug-ins/metadata/tests/files/test.xmp
index b61eb38..086ea11 100644
--- a/plug-ins/metadata/tests/files/test.xmp
+++ b/plug-ins/metadata/tests/files/test.xmp
@@ -18,7 +18,14 @@
     <rdf:li xml:lang='x-default'>bla</rdf:li>
     <rdf:li xml:lang='de_DE'>Deutsche Beschreibung</rdf:li>
    </rdf:Alt>
-  </dc:description>
+ </dc:description>
+ <dc:subject>
+   <rdf:Bag>
+     <rdf:li>Test</rdf:li>
+     <rdf:li>Image</rdf:li>
+     <rdf:li>Photoshop</rdf:li>
+   </rdf:Bag>
+ </dc:subject>
  </rdf:Description>
 
  <rdf:Description rdf:about=""
diff --git a/plug-ins/metadata/xmp-encode.c b/plug-ins/metadata/xmp-encode.c
index 0ea95e7..5f683e1 100644
--- a/plug-ins/metadata/xmp-encode.c
+++ b/plug-ins/metadata/xmp-encode.c
@@ -128,10 +128,15 @@ gen_property (GString            *buffer,
     case XMP_TYPE_JOB_BAG:
       g_string_append_printf (buffer, "  <%s:%s>\n   <rdf:Bag>\n",
                               schema->prefix, property->name);
-      for (i = 0; value_array[i] != NULL; i++)
+      if (value != NULL)
+        updated_values = g_strsplit (value, ";", 0);
+      else
+        updated_values = (gchar **) value_array;
+
+      for (i = 0; updated_values[i] != NULL; i++)
         {
           gen_element (buffer, 4,
-                       "rdf", "li", value_array[i],
+                       "rdf", "li", updated_values[i],
                        NULL);
         }
       g_string_append_printf (buffer, "   </rdf:Bag>\n  </%s:%s>\n",



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]