[banshee] YouTubeTile: Fix contruction of the playback URI (bgo#651743)
- From: Bertrand Lorentz <blorentz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] YouTubeTile: Fix contruction of the playback URI (bgo#651743)
- Date: Mon, 28 Nov 2011 15:00:28 +0000 (UTC)
commit d4da04690ab04bb005a0f764a906eb8d445d3a06
Author: Bertrand Lorentz <bertrand lorentz gmail com>
Date: Mon Nov 28 15:56:05 2011 +0100
YouTubeTile: Fix contruction of the playback URI (bgo#651743)
The values for the YouTubeQuery.VideoFormat enum in gdata are completely
wrong, so we use our own enum with correct values.
.../Banshee.YouTube.Gui/YouTubeTile.cs | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
---
diff --git a/src/Extensions/Banshee.YouTube/Banshee.YouTube.Gui/YouTubeTile.cs b/src/Extensions/Banshee.YouTube/Banshee.YouTube.Gui/YouTubeTile.cs
index a4bf1ce..078798d 100644
--- a/src/Extensions/Banshee.YouTube/Banshee.YouTube.Gui/YouTubeTile.cs
+++ b/src/Extensions/Banshee.YouTube/Banshee.YouTube.Gui/YouTubeTile.cs
@@ -78,6 +78,16 @@ namespace Banshee.YouTube.Gui
public int RatingValue { get; private set; }
public string Thumbnail { get; private set; }
+ // FIXME: The YouTubeQuery.VideoFormat enum values are wrong in google-gdata <= 1.9,
+ // so we use our own, with correct values.
+ // See http://code.google.com/p/google-gdata/issues/detail?id=553 and bgo#651743.
+ private enum YouTubeVideoFormat {
+ FormatUndefined = 0,
+ RTSP = 1,
+ Embeddable = 5,
+ Mobile = 6,
+ }
+
public YouTubeTileData (Video video)
{
BansheePlaybackUri = GetPlaybackUri (video);
@@ -97,8 +107,8 @@ namespace Banshee.YouTube.Gui
private static string GetPlaybackUri (Video yt_video)
{
- int flv = (int)YouTubeQuery.VideoFormat.Embeddable;
- int mobile = (int)YouTubeQuery.VideoFormat.Mobile;
+ int flv = (int)YouTubeVideoFormat.Embeddable;
+ int mobile = (int)YouTubeVideoFormat.Mobile;
const string format_param = "&fmt=18"; // Assumes user has broadband connection
string video_id = yt_video.VideoId;
string playback_uri = String.Empty;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]